These conditions appear to always be true.
@clayborg do you remember the reason why these exist?
aprantl on Mar 1 2019, 10:33 AM.Authored by
I generally agree with this, but we need to decide what to do on a case-by-case basis. So far I found four categories of LLDB_CONFIGURATION_DEBUG
there may be other cases that I haven't found yet.
Also I should note that we can only use LLVM defines that are provided by the Xcode project until we reach the point where Apple builds LLDB with CMake and the CMake-generated Xcode file is good enough to replace the hand-written one. This is a transitional restriction, but it's a longer project...
Additional logging should really go through the Verbose version of whatever log channel is appropriate. The additional code won't get run in the normal logging case, so there's no reason to throw it away.