Page MenuHomePhabricator

[AMDGPU] Mark ds instructions as meybeAtomic
ClosedPublic

Authored by rampitec on Feb 28 2019, 4:37 PM.

Details

Summary

These were not recognized as potential atomics by memory legalizer.
The test was working not because legalizer did a right thing, but
because it has skipped all these instructions. When I have fixed
DS desciption test started to fail because region address has
changed from 4 to 2 a while ago.

Diff Detail

Repository
rL LLVM

Event Timeline

rampitec created this revision.Feb 28 2019, 4:37 PM
t-tye accepted this revision.Feb 28 2019, 8:13 PM

LGTM

This revision is now accepted and ready to land.Feb 28 2019, 8:13 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2019, 11:59 PM
arsenm added inline comments.Mar 1 2019, 9:40 AM
llvm/trunk/lib/Target/AMDGPU/DSInstructions.td
21

Doesn't this need to be overridden for things like swizzle, and for the sub-dword sized operations?