This is an archive of the discontinued LLVM Phabricator instance.

Differential D58799

[WebAssembly] Fix crash when @llvm.global_dtors is external
ClosedPublic

Authored by tlively on Feb 28 2019, 4:00 PM.

Details

Reviewers
aheejin
sbc100
Commits
rGae79f42a2fdd: [WebAssembly] Fix crash when @llvm.global_dtors is external
rL355157: [WebAssembly] Fix crash when @llvm.global_dtors is external

Diff Detail

Repository
rL LLVM

Event Timeline

tlively created this revision.Feb 28 2019, 4:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2019, 4:00 PM
Herald added subscribers: llvm-commits, sunfish, hiraditya and 3 others. · View Herald Transcript
Harbormaster completed remote builds in B28649: Diff 188804.Feb 28 2019, 4:00 PM
sbc100 accepted this revision.Feb 28 2019, 4:03 PM

Does this ever happen in practice?

This revision is now accepted and ready to land.Feb 28 2019, 4:03 PM
tlively added a comment.Feb 28 2019, 4:07 PM

Unclear, but bugpoint was running into it while I was trying to reduce a test case for an unrelated bug.

Closed by commit rL355157: [WebAssembly] Fix crash when @llvm.global_dtors is external (authored by tlively). · Explain WhyFeb 28 2019, 4:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Target/
WebAssembly/
2 lines
test/
CodeGen/
WebAssembly/
9 lines

Diff 188806

llvm/trunk/lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
ModulePass *llvm::createWebAssemblyLowerGlobalDtors() { ModulePass *llvm::createWebAssemblyLowerGlobalDtors() {
return new LowerGlobalDtors(); return new LowerGlobalDtors();
} }
bool LowerGlobalDtors::runOnModule(Module &M) { bool LowerGlobalDtors::runOnModule(Module &M) {
LLVM_DEBUG(dbgs() << "********** Lower Global Destructors **********\n"); LLVM_DEBUG(dbgs() << "********** Lower Global Destructors **********\n");
GlobalVariable *GV = M.getGlobalVariable("llvm.global_dtors"); GlobalVariable *GV = M.getGlobalVariable("llvm.global_dtors");
if (!GV) if (!GV || !GV->hasInitializer())
return false; return false;
const ConstantArray *InitList = dyn_cast<ConstantArray>(GV->getInitializer()); const ConstantArray *InitList = dyn_cast<ConstantArray>(GV->getInitializer());
if (!InitList) if (!InitList)
return false; return false;
// Sanity-check @llvm.global_dtor's type. // Sanity-check @llvm.global_dtor's type.
auto *ETy = dyn_cast<StructType>(InitList->getType()->getElementType()); auto *ETy = dyn_cast<StructType>(InitList->getType()->getElementType());
▲ Show 20 Lines • Show All 118 Lines • Show Last 20 Lines

llvm/trunk/test/CodeGen/WebAssembly/global_dtors.ll

; RUN: llc < %s
target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown"
; Check that we do not crash when attempting to lower away
; global_dtors without a definition.
@llvm.global_dtors = external global [2 x { i32, void ()*, i8* }]