This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Enable SuggestMissingIncludes by default.
ClosedPublic

Authored by ioeric on Feb 28 2019, 3:09 AM.

Reviewers

Commits

Summary

This seems to work stably now. Turn on by default.

Repository

rCTE Clang Tools Extra

Build Status

Buildable 28629
Build 28628: arc lint + arc unit

This revision is now accepted and ready to land.Feb 28 2019, 3:41 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

clangd/

tool/

2 lines

Show First 20 Lines • Show All 211 Lines • ▼ Show 20 Lines	static llvm::cl::opt<bool> EnableClangTidy(
"clang-tidy",		"clang-tidy",
llvm::cl::desc("Enable clang-tidy diagnostics."),		llvm::cl::desc("Enable clang-tidy diagnostics."),
llvm::cl::init(false));		llvm::cl::init(false));

static llvm::cl::opt<bool> SuggestMissingIncludes(		static llvm::cl::opt<bool> SuggestMissingIncludes(
"suggest-missing-includes",		"suggest-missing-includes",
llvm::cl::desc("Attempts to fix diagnostic errors caused by missing "		llvm::cl::desc("Attempts to fix diagnostic errors caused by missing "
"includes using index."),		"includes using index."),
llvm::cl::init(false));		llvm::cl::init(true));

namespace {		namespace {

/// \brief Supports a test URI scheme with relaxed constraints for lit tests.		/// \brief Supports a test URI scheme with relaxed constraints for lit tests.
/// The path in a test URI will be combined with a platform-specific fake		/// The path in a test URI will be combined with a platform-specific fake
/// directory to form an absolute path. For example, test:///a.cpp is resolved		/// directory to form an absolute path. For example, test:///a.cpp is resolved
/// C:\clangd-test\a.cpp on Windows and /clangd-test/a.cpp on Unix.		/// C:\clangd-test\a.cpp on Windows and /clangd-test/a.cpp on Unix.
class TestScheme : public URIScheme {		class TestScheme : public URIScheme {
▲ Show 20 Lines • Show All 239 Lines • Show Last 20 Lines