This is an archive of the discontinued LLVM Phabricator instance.

hwasan: Rename source files from cc to cpp
ClosedPublic

Authored by thakis on Feb 25 2019, 7:12 AM.

Details

Summary

As discussed elsewhere: LLVM uses cpp as its C++ source extension; the sanitizers should too. This updates files in hwasan.

Patch generated by for f in lib/hwasan/*.cc ; do svn mv $f ${f%.cc}.cpp; done followed by for f in lib/hwasan/*.cpp ; do sed -i '' -e '1s/\.cc -/.cpp /' $f; done; CMakeLists.txt updated manually.

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Feb 25 2019, 7:12 AM
pcc accepted this revision.Feb 26 2019, 12:43 PM

LGTM

lib/hwasan/hwasan.cc
1 ↗(On Diff #188166)

Maybe also update this to .cpp? (Same for other files.)

This revision is now accepted and ready to land.Feb 26 2019, 12:43 PM
thakis edited the summary of this revision. (Show Details)Feb 27 2019, 7:41 AM
thakis edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2019, 7:44 AM
Herald added a subscriber: delcypher. · View Herald Transcript
thakis marked 2 inline comments as done.Feb 27 2019, 7:46 AM
thakis added inline comments.
lib/hwasan/hwasan.cc
1 ↗(On Diff #188166)

Done, thanks.

Should I upload patches for the other directories, or should I just land the changes there?

pcc added a subscriber: eugenis.Feb 27 2019, 1:45 PM
pcc added inline comments.
lib/hwasan/hwasan.cc
1 ↗(On Diff #188166)

I'd be fine either way, but I noticed that @eugenis needed to fix something up after this change in r355028 so please also watch out for similar issues when renaming the other files.

compiler-rt/trunk/lib/hwasan/hwasan_thread.cpp