This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Improve readability of EH tests
ClosedPublic

Authored by aheejin on Feb 22 2019, 4:32 PM.

Details

Summary
  • Indent check lines to easily figure out try-catch-end structure
  • Add the original C++ code the tests were genereated from
  • Add a few more lines to make the structure more readable
  • Rename a couple function / structures
  • Temporarily delete check lines for test1 in cfg-stackify-eh.ll because it will be updated in a later CL soon and there's no point of making these look better here

Diff Detail

Event Timeline

aheejin created this revision.Feb 22 2019, 4:32 PM
aheejin edited the summary of this revision. (Show Details)Feb 22 2019, 4:35 PM
aheejin edited the summary of this revision. (Show Details)
aheejin updated this revision to Diff 188025.Feb 22 2019, 7:21 PM
  • More work
aheejin edited the summary of this revision. (Show Details)Feb 22 2019, 7:28 PM
aheejin updated this revision to Diff 188060.Feb 23 2019, 2:26 PM
  • Add block / end_blocks as well to make structure clearer
aheejin updated this revision to Diff 188102.Feb 25 2019, 12:06 AM

Add back CHECK lines for test2 in cfg-stackify-eh.ll
(turns out it is not gonna change in D58486)

aheejin edited the summary of this revision. (Show Details)Feb 25 2019, 12:07 AM
aheejin updated this revision to Diff 188115.Feb 25 2019, 2:59 AM

Add label and branch annotations to cfg-stackify-eh.ll

aheejin updated this revision to Diff 188123.Feb 25 2019, 3:45 AM

Add annotations to rethrow too

dschuff accepted this revision.Feb 25 2019, 1:15 PM

LGTM, this is a nice improvement.

test/CodeGen/WebAssembly/cfg-stackify-eh.ll
94

Could you be more specific here? e.g. "fill in the check lines when we are able to compile this" or "when XXX condition is met"

This revision is now accepted and ready to land.Feb 25 2019, 1:15 PM
aheejin updated this revision to Diff 188298.Feb 25 2019, 7:26 PM
aheejin marked 2 inline comments as done.

Address comment

test/CodeGen/WebAssembly/cfg-stackify-eh.ll
94

Done. And it's gonna be filled in in D58605. (With that bug, the indentation cannot be done here because that bug creates incorrect structures like

try
  block
catch
  end_block
end_try
aheejin edited the summary of this revision. (Show Details)Feb 25 2019, 7:28 PM
This revision was automatically updated to reflect the committed changes.