This is an archive of the discontinued LLVM Phabricator instance.

Differential D58508

[ELF][test]Remove unnecessary empty symbol references in yaml/add missing symbols for relocs
ClosedPublic

Authored by jhenderson on Feb 21 2019, 7:40 AM.

Details

Reviewers
ruiu
grimar
jakehehrlich
• espindola
Commits
rG0cc32dd4a134: [ELF][test]Remove unnecessary empty symbol references in yaml/add missing…
rLLD354666: [ELF][test]Remove unnecessary empty symbol references in yaml/add missing…
rL354666: [ELF][test]Remove unnecessary empty symbol references in yaml/add missing…
Summary

yaml2obj used to require the Symbol field in relocations, but it hasn't done so for a couple of years. I am making a separate change to yaml2obj that will look up the symbol by name or index, if present, and emit an error if not found. This will mean that an explicit symbol reference (even to an empty-named symbol) that does not reference a symbol declared in the yaml will result in an error.

This patch updates tests that would otherwise start emitting errors.

Diff Detail

Repository
rL LLVM

Revision Contents

Diff 187918

lld/trunk/test/ELF/arm-v4bx.test

Show All 21 Lines - Name: .text
Content: 1EFF2F01 Content: 1EFF2F01
- Name: .rel.text - Name: .rel.text
Type: SHT_REL Type: SHT_REL
Link: .symtab Link: .symtab
AddressAlign: 0x0000000000000004 AddressAlign: 0x0000000000000004
Info: .text Info: .text
Relocations: Relocations:
- Offset: 0x0000000000000000 - Offset: 0x0000000000000000
Symbol: ''
Type: R_ARM_V4BX Type: R_ARM_V4BX
Symbols: Symbols:
Global: Global:
- Name: _start - Name: _start
Section: .text Section: .text
Local: Local:
- Name: .text - Name: .text
Type: STT_SECTION Type: STT_SECTION
Section: .text Section: .text
DynamicSymbols: DynamicSymbols:

lld/trunk/test/ELF/icf10.test

Show All 22 Lines - Name: .text.bar
Flags: [ SHF_ALLOC, SHF_EXECINSTR] Flags: [ SHF_ALLOC, SHF_EXECINSTR]
Content: "FFFFFFFFFFFFFFFF" Content: "FFFFFFFFFFFFFFFF"
- Name: .rela.text.foo - Name: .rela.text.foo
Type: SHT_RELA Type: SHT_RELA
Link: .symtab Link: .symtab
Info: .text.foo Info: .text.foo
Relocations: Relocations:
- Offset: 0x0000000000000000 - Offset: 0x0000000000000000
Symbol: ''
Type: R_X86_64_NONE Type: R_X86_64_NONE
- Name: .rela.text.bar - Name: .rela.text.bar
Type: SHT_RELA Type: SHT_RELA
Link: .symtab Link: .symtab
Info: .text.bar Info: .text.bar
Relocations: Relocations:
- Offset: 0x0000000000000001 - Offset: 0x0000000000000001
Symbol: ''
Type: R_X86_64_NONE Type: R_X86_64_NONE

lld/trunk/test/ELF/icf11.test

Show All 27 Lines - Name: .text.bar
Flags: [ SHF_ALLOC, SHF_EXECINSTR] Flags: [ SHF_ALLOC, SHF_EXECINSTR]
Content: "FFFFFFFFFFFFFFFF" Content: "FFFFFFFFFFFFFFFF"
- Name: .rela.text.foo - Name: .rela.text.foo
Type: SHT_RELA Type: SHT_RELA
Link: .symtab Link: .symtab
Info: .text.foo Info: .text.foo
Relocations: Relocations:
- Offset: 0x0000000000000000 - Offset: 0x0000000000000000
Symbol: ''
Type: R_X86_64_NONE Type: R_X86_64_NONE
- Name: .rela.text.bar - Name: .rela.text.bar
Type: SHT_RELA Type: SHT_RELA
Link: .symtab Link: .symtab
Info: .text.bar Info: .text.bar
Relocations: Relocations:
- Offset: 0 - Offset: 0
Symbol: zed Symbol: zed
Type: R_X86_64_64 Type: R_X86_64_64
Symbols: Symbols:
Global: Global:
- Name: zed - Name: zed
Type: STT_FUNC Type: STT_FUNC
Section: .text Section: .text
Value: 0x0 Value: 0x0
Size: 8 Size: 8

lld/trunk/test/ELF/invalid/reloc-section-reordered.test

Show All 22 Lines Relocations:
- Offset: 0 - Offset: 0
Symbol: .text Symbol: .text
Type: R_X86_64_NONE Type: R_X86_64_NONE
- Type: SHT_PROGBITS - Type: SHT_PROGBITS
Name: .text Name: .text
Flags: [ SHF_ALLOC, SHF_EXECINSTR ] Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
AddressAlign: 0x04 AddressAlign: 0x04
Content: "FFFFFFFFFFFFFFFF" Content: "FFFFFFFFFFFFFFFF"
Symbols:
Local:
- Name: .text
Type: STT_SECTION
Section: .text

lld/trunk/test/ELF/relocation-dtrace.test

Show All 14 Lines - Name: .text
Type: SHT_PROGBITS Type: SHT_PROGBITS
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
- Name: .rela.text - Name: .rela.text
Type: SHT_RELA Type: SHT_RELA
Link: .symtab Link: .symtab
Info: .text Info: .text
Relocations: Relocations:
- Offset: 0x0000000000000000 - Offset: 0x0000000000000000
Symbol: ''
Type: R_X86_64_NONE Type: R_X86_64_NONE

lld/trunk/test/ELF/relocation-none-aarch64.test

Show All 14 Lines - Type: SHT_PROGBITS
Flags: [ SHF_ALLOC, SHF_EXECINSTR ] Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
Content: "00000000" Content: "00000000"
- Type: SHT_RELA - Type: SHT_RELA
Name: .rela.text Name: .rela.text
Link: .symtab Link: .symtab
Info: .text Info: .text
Relocations: Relocations:
- Offset: 0 - Offset: 0
Symbol: ''
Type: R_AARCH64_NONE Type: R_AARCH64_NONE

lld/trunk/test/ELF/relocation-none-i686.test

Show All 13 Lines - Name: .text
Type: SHT_PROGBITS Type: SHT_PROGBITS
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
- Name: .rel.text - Name: .rel.text
Type: SHT_RELA Type: SHT_RELA
Link: .symtab Link: .symtab
Info: .text Info: .text
Relocations: Relocations:
- Offset: 0x0000000000000000 - Offset: 0x0000000000000000
Symbol: ''
Type: R_386_NONE Type: R_386_NONE

lld/trunk/test/ELF/undef-broken-debug.test

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines Relocations:
Symbol: .debug_line Symbol: .debug_line
Type: R_X86_64_32 Type: R_X86_64_32
- Name: .debug_abbrev - Name: .debug_abbrev
Type: SHT_PROGBITS Type: SHT_PROGBITS
AddressAlign: 0x0000000000000001 AddressAlign: 0x0000000000000001
Content: '0111001017000000' Content: '0111001017000000'
Symbols: Symbols:
Local:
- Name: .debug_abbrev
Type: STT_SECTION
Section: .debug_abbrev
- Name: .debug_line
Type: STT_SECTION
Section: .debug_line
Global: Global:
- Name: _start - Name: _start
Section: .text Section: .text
- Name: bar - Name: bar