This is an archive of the discontinued LLVM Phabricator instance.

Differential D58422

ELF: Remove field for .interp in InStruct. NFC.
ClosedPublic

Authored by pcc on Feb 19 2019, 6:06 PM.

Details

Reviewers
ruiu
• espindola
MaskRay
Commits
rG7cca803d4cbe: ELF: Remove field for .interp in InStruct. NFC.
rLLD354428: ELF: Remove field for .interp in InStruct. NFC.
rL354428: ELF: Remove field for .interp in InStruct. NFC.
Summary

This field is unreferenced outside of createSyntheticSections.

Diff Detail

Event Timeline

pcc created this revision.Feb 19 2019, 6:06 PM
Herald added a reviewer: • espindola. · View Herald TranscriptFeb 19 2019, 6:06 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: arichardson, emaste. · View Herald Transcript
Harbormaster completed remote builds in B28311: Diff 187483.Feb 19 2019, 6:08 PM
ruiu accepted this revision.Feb 19 2019, 6:23 PM

LGTM

This revision is now accepted and ready to land.Feb 19 2019, 6:23 PM
MaskRay accepted this revision.Feb 19 2019, 6:24 PM
Closed by commit rL354428: ELF: Remove field for .interp in InStruct. NFC. (authored by pcc). · Explain WhyFeb 19 2019, 6:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
ELF/
1 line
6 lines

Diff 187483

lld/ELF/SyntheticSections.h

Show First 20 Lines • Show All 1,001 Lines • ▼ Show 20 Linesstruct InStruct {
BuildIdSection *BuildId; BuildIdSection *BuildId;
EhFrameHeader *EhFrameHdr; EhFrameHeader *EhFrameHdr;
EhFrameSection *EhFrame; EhFrameSection *EhFrame;
SyntheticSection *Dynamic; SyntheticSection *Dynamic;
StringTableSection *DynStrTab; StringTableSection *DynStrTab;
SymbolTableBaseSection *DynSymTab; SymbolTableBaseSection *DynSymTab;
GnuHashTableSection *GnuHashTab; GnuHashTableSection *GnuHashTab;
HashTableSection *HashTab; HashTableSection *HashTab;
InputSection *Interp;
GdbIndexSection *GdbIndex; GdbIndexSection *GdbIndex;
GotSection *Got; GotSection *Got;
GotPltSection *GotPlt; GotPltSection *GotPlt;
IgotPltSection *IgotPlt; IgotPltSection *IgotPlt;
PPC64LongBranchTargetSection *PPC64LongBranchTarget; PPC64LongBranchTargetSection *PPC64LongBranchTarget;
MipsGotSection *MipsGot; MipsGotSection *MipsGot;
MipsRldMapSection *MipsRldMap; MipsRldMapSection *MipsRldMap;
PltSection *Plt; PltSection *Plt;
Show All 25 Lines

lld/ELF/Writer.cpp

Show First 20 Lines • Show All 282 Lines • ▼ Show 20 Lines if (Config->AndroidPackDynRelocs) {
In.RelaDyn = make<RelocationSection<ELFT>>( In.RelaDyn = make<RelocationSection<ELFT>>(
Config->IsRela ? ".rela.dyn" : ".rel.dyn", Config->ZCombreloc); Config->IsRela ? ".rela.dyn" : ".rel.dyn", Config->ZCombreloc);
} }
In.ShStrTab = make<StringTableSection>(".shstrtab", false); In.ShStrTab = make<StringTableSection>(".shstrtab", false);
Out::ProgramHeaders = make<OutputSection>("", 0, SHF_ALLOC); Out::ProgramHeaders = make<OutputSection>("", 0, SHF_ALLOC);
Out::ProgramHeaders->Alignment = Config->Wordsize; Out::ProgramHeaders->Alignment = Config->Wordsize;
if (needsInterpSection()) { if (needsInterpSection())
In.Interp = createInterpSection(); Add(createInterpSection());
Add(In.Interp);
}
if (Config->Strip != StripPolicy::All) { if (Config->Strip != StripPolicy::All) {
In.StrTab = make<StringTableSection>(".strtab", false); In.StrTab = make<StringTableSection>(".strtab", false);
In.SymTab = make<SymbolTableSection<ELFT>>(*In.StrTab); In.SymTab = make<SymbolTableSection<ELFT>>(*In.StrTab);
In.SymTabShndx = make<SymtabShndxSection>(); In.SymTabShndx = make<SymtabShndxSection>();
} }
if (Config->BuildId != BuildIdKind::None) { if (Config->BuildId != BuildIdKind::None) {
▲ Show 20 Lines • Show All 2,277 Lines • Show Last 20 Lines