This is an archive of the discontinued LLVM Phabricator instance.

[Tsan] Fix the signal_recursive.cc test to build on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Oct 17 2014, 3:09 AM.

Diff Detail

Event Timeline

kutuzov.viktor.84 retitled this revision from to [Tsan] Fix the signal_recursive.cc test to build on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added reviewers: kcc, glider, samsonov.
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), emaste.
emaste added inline comments.Oct 17 2014, 6:39 AM
test/tsan/signal_recursive.cc
14–18

Is the specific signal of interest here, or do we just need two arbitrary signals? If the latter, can we just use SIGUSR1 instead?

test/tsan/signal_recursive.cc
14–18

To me they look like two arbitrary "informative" signals that do not need any special handling. From this point of view, SIGINFO may be somewhat more expressive than SIGUSR1, but I'm not sure.

Dmitry, can you please let us know if SIGPWR and SIGXCPU have been chosen for a reason?

dvyukov edited edge metadata.Oct 21 2014, 7:07 AM

These weird signals were copied from a user bug report. You, you can just replace them with SIGUSR1/2.

kutuzov.viktor.84 edited edge metadata.

Reworked to use SIGUSR1/2 signals.

dvyukov accepted this revision.Oct 23 2014, 4:47 AM
dvyukov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 23 2014, 4:47 AM
Diffusion closed this revision.Oct 24 2014, 2:30 AM
Diffusion updated this revision to Diff 15383.

Closed by commit rL220550 (authored by vkutuzov).