See bug 39331: https://bugs.llvm.org/show_bug.cgi?id=39331
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp | ||
---|---|---|
948 ↗ | (On Diff #187028) | Why can't you just write to O directly without the intermediate string? |
lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp | ||
---|---|---|
948 ↗ | (On Diff #187028) | The last comma in the list of modifiers should not be emitted, otherwise we get something like this: gpr_idx(SRC1,) I found no simpler logic to handle this problem. Any ideas? |
lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp | ||
---|---|---|
948 ↗ | (On Diff #187028) | Something like bool Comma = false; for (unsigne Test: {src0, src1...}) { if (!(Val & Test) continue if (Comma) OS << ','; OS << srcName(Test); Comma = true; } |