Page MenuHomePhabricator

[lit] Set --single-process for single tests and --threads=1
ClosedPublic

Authored by yln on Feb 14 2019, 12:57 PM.

Details

Summary

Automatically upgrade debugging experience (single process, no thread
pool) when:

  1. we only run a single test
  2. user specifies -j1

Fix --max-failures in single process mode. Option did not have an
effect in single process mode.

Add display feedback for single process mode. Adapted test.

Improve argument checking (require positive integers).

--single-process is now essentially an alias for -j1. Should we
remove it?

Diff Detail

Repository
rL LLVM

Event Timeline

yln created this revision.Feb 14 2019, 12:57 PM
rnk accepted this revision.Feb 14 2019, 1:12 PM

Looks good!

--single-process is now essentially an alias for -j1. Should we remove it?

I think so. I'd commit this, and then send a quick follow-up patch to remove --single-process.

llvm/utils/lit/lit/main.py
483 ↗(On Diff #186902)

Maybe say "workers" instead of "threads" since lit has been using multiprocessing everywhere for a long time now.

This revision is now accepted and ready to land.Feb 14 2019, 1:12 PM
yln marked an inline comment as done.Feb 14 2019, 2:07 PM

Okay, will do.
Thanks for the quick review! :)

This revision was automatically updated to reflect the committed changes.