This is an archive of the discontinued LLVM Phabricator instance.

Differential D58217

AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir
ClosedPublic

Authored by tstellar on Feb 13 2019, 4:29 PM.

Details

Reviewers
t.p.northover
• jpaquette
paquette
Commits
rG96ddd7d7f001: Merging r354497: --------------------------------------------------------------…
rL354555: Merging r354497:
rG13f45590e349: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir
rL354497: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir
Summary

This test was failing in one of our setups because the generated ModuleID
had the full path of the test file and that path contained the string
BL.

Diff Detail

Event Timeline

tstellar created this revision.Feb 13 2019, 4:29 PM
Herald added a reviewer: paquette. · View Herald TranscriptFeb 13 2019, 4:29 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: kristof.beyls, javed.absar. · View Herald Transcript
Harbormaster completed remote builds in B28127: Diff 186773.Feb 13 2019, 4:29 PM
tstellar added a comment.Feb 13 2019, 4:30 PM

Example of test failure: https://jenkins-continuous-infra.apps.ci.centos.org/job/fedora-f29-pr-pipeline/51/artifact/package-tests/logs/FAIL_str_regression-tests.log

paquette accepted this revision.Feb 13 2019, 4:30 PM

Oh no! LGTM

This revision is now accepted and ready to land.Feb 13 2019, 4:30 PM
Closed by commit rL354497: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir (authored by tstellar). · Explain WhyFeb 20 2019, 10:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
CodeGen/
AArch64/
1 line

Diff 186773

llvm/test/CodeGen/AArch64/machine-outliner-bad-adrp.mir

# RUN: llc -mtriple=aarch64--- -verify-machineinstrs -simplify-mir -run-pass=machine-outliner %s -o - | FileCheck %s # RUN: llc -mtriple=aarch64--- -verify-machineinstrs -simplify-mir -run-pass=machine-outliner %s -o - | FileCheck %s
--- | --- |
define void @foo() #0 { define void @foo() #0 {
ret void ret void
} }
attributes #0 = { noredzone } attributes #0 = { noredzone }
... ...
--- ---
name: foo name: foo
# CHECK-LABEL: name: foo
tracksRegLiveness: true tracksRegLiveness: true
constants: constants:
- id: 0 - id: 0
value: 'float 1.990000e+02' value: 'float 1.990000e+02'
alignment: 4 alignment: 4
isTargetSpecific: false isTargetSpecific: false
body: | body: |
bb.0: bb.0:
Show All 22 Lines