Page MenuHomePhabricator

Fix thread sanitizer on aarch64
ClosedPublic

Authored by yuri on Feb 13 2019, 3:44 AM.

Details

Summary

Call cur_thread_init() from COMMON_INTERCEPTORs

Diff Detail

Event Timeline

yuri created this revision.Feb 13 2019, 3:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2019, 3:44 AM
Herald added subscribers: Restricted Project, llvm-commits, kristof.beyls and 2 others. · View Herald Transcript
yuri updated this revision to Diff 186624.Feb 13 2019, 3:46 AM

Patch with context

rovka added a comment.Feb 13 2019, 4:06 AM

Testing in progress, I'll let you know how it went. Thanks for the quick fix!

rovka added a comment.Feb 13 2019, 4:15 AM

This seems to solve the problem on AArch64. I'll let the others approve if it's the right fix from a compiler-rt perspective.

dvyukov accepted this revision.Feb 13 2019, 4:30 AM

Looks good to me.

How do we submit this now? Perhaps we need to squash the main fibers patch, check_analyze patch and this into one.

This revision is now accepted and ready to land.Feb 13 2019, 4:30 AM
rovka added a comment.Feb 13 2019, 4:52 AM

Looks good to me.

How do we submit this now? Perhaps we need to squash the main fibers patch, check_analyze patch and this into one.

I think squashing would be best, since that makes cherry-picking easy if needed.

dvyukov closed this revision.Feb 13 2019, 5:21 AM

This is submitted as part of 353947