Page MenuHomePhabricator

AMDGPU: Remove debugger related subtarget features
ClosedPublic

Authored by arsenm on Feb 12 2019, 4:46 PM.

Details

Summary

As far as I know these aren't needed anymore.

Diff Detail

Event Timeline

arsenm created this revision.Feb 12 2019, 4:46 PM

I am in favor of removing these. Clang will also need to be updated around here:
https://github.com/llvm-mirror/clang/blob/master/lib/Driver/ToolChains/AMDGPU.cpp#L41

I tried to do the same thing about 6 months ago, but got a push back from @t-tye. @t-tye is it ok to remove these now?

t-tye accepted this revision.Feb 21 2019, 11:26 AM

LGTM

This revision is now accepted and ready to land.Feb 21 2019, 11:26 AM

Can SIProgramInfo::DebuggerWavefrontPrivateSegmentOffsetSGPR and SIProgramInfo::DebuggerPrivateSegmentBufferSGPR be completely deleted?

arsenm updated this revision to Diff 187861.Feb 21 2019, 1:55 PM

Remove more leftovers

arsenm closed this revision.Feb 21 2019, 3:27 PM

r354634