Page MenuHomePhabricator

[Builtins] Treat `bcmp` as a builtin.
ClosedPublic

Authored by courbet on Feb 12 2019, 7:23 AM.

Diff Detail

Event Timeline

courbet created this revision.Feb 12 2019, 7:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2019, 7:23 AM
Herald added a subscriber: kristina. · View Herald Transcript

This looks essentially fine, but I'd like to see some basic test coverage for the changes to warnings and constant evaluation.

courbet updated this revision to Diff 186644.Feb 13 2019, 6:44 AM
  • Add tests for warnings.
  • Fix signature for intrinsic.
courbet updated this revision to Diff 186645.Feb 13 2019, 6:50 AM
  • add __builtin_bcmp constant evaluation tests.
courbet updated this revision to Diff 186651.Feb 13 2019, 7:12 AM

Update tests after constness changes.

jyknight accepted this revision.Feb 13 2019, 11:09 AM

Looks reasonable to me.

This revision is now accepted and ready to land.Feb 13 2019, 11:09 AM
This revision was automatically updated to reflect the committed changes.