And change the output ("X86 features" -> "x86 feature") a bit.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 28047 Build 28046: arc lint + arc unit
Event Timeline
llvm/trunk/tools/llvm-readobj/ELFDumper.cpp | ||
---|---|---|
3653 ↗ | (On Diff #186576) | nit: pr_data violates the LLVM variables naming style which says they should be uppercase. |
llvm/trunk/tools/llvm-readobj/ELFDumper.cpp | ||
---|---|---|
3653 ↗ | (On Diff #186576) | I know but pr_data is used by the ABI. Keeping the name unchanged makes it easy for reference and validation purpose. The ELF naming is used in several other places. This is a simple case so I have no strong preference:) |
llvm/trunk/tools/llvm-readobj/ELFDumper.cpp | ||
---|---|---|
3653 ↗ | (On Diff #186576) | I do not think ABI has a higher priority over LLVM coding style. |
llvm/trunk/tools/llvm-readobj/ELFDumper.cpp | ||
---|---|---|
3653 ↗ | (On Diff #186576) | At least you should not be able to find something like that in LLVM coding style documents :] |