Page MenuHomePhabricator

[llvm-readobj] Dump GNU_PROPERTY_X86_FEATURE_2_{NEEDED,USED} notes in .note.gnu.property
ClosedPublic

Authored by MaskRay on Feb 12 2019, 3:33 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Feb 12 2019, 3:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2019, 3:33 AM
rupprecht accepted this revision.Feb 12 2019, 7:09 AM
This revision is now accepted and ready to land.Feb 12 2019, 7:09 AM
This revision was automatically updated to reflect the committed changes.
grimar added inline comments.Feb 13 2019, 1:47 AM
llvm/trunk/tools/llvm-readobj/ELFDumper.cpp
3653

nit: pr_data violates the LLVM variables naming style which says they should be uppercase.
Perhaps it could be PrData.

MaskRay marked an inline comment as done.Feb 13 2019, 3:38 AM
MaskRay added inline comments.
llvm/trunk/tools/llvm-readobj/ELFDumper.cpp
3653

I know but pr_data is used by the ABI. Keeping the name unchanged makes it easy for reference and validation purpose. The ELF naming is used in several other places. This is a simple case so I have no strong preference:)

grimar added inline comments.Feb 13 2019, 3:44 AM
llvm/trunk/tools/llvm-readobj/ELFDumper.cpp
3653

I do not think ABI has a higher priority over LLVM coding style.

grimar added inline comments.Feb 13 2019, 3:46 AM
llvm/trunk/tools/llvm-readobj/ELFDumper.cpp
3653

At least you should not be able to find something like that in LLVM coding style documents :]