[CMake][runtimes] Use variables rather than ":" delimiters

[phosek]

Summary

This is a follow up to D37644, this block was missed in that change.

[smeenai]

llvm/runtimes/CMakeLists.txt

392–394

Super nit: the other block seems to have the install target line after the regular target line, so it'd be nice to be consistent.

394

I'm confused. Should this be something like the following instead?

list(APPEND ${name}_extra_targets install-${component}-${name} ${component}-${name})

[phosek]

llvm/runtimes/CMakeLists.txt

394

Yes, this is a copy-pasta error.

[smeenai]

LGTM

llvm/runtimes/CMakeLists.txt

394

Super nit part 2: switch the append order around to match the set command order?

llvm/runtimes/CMakeLists.txt

function(runtime_register_target name target)
     endforeach()
 
     foreach(target_name IN LISTS SUB_COMPONENTS SUB_INSTALL_TARGETS)
       set(${target_name}-${name} ${target_name})
       list(APPEND ${name}_extra_targets ${target_name}-${name})
     endforeach()
 
     foreach(component ${LLVM_RUNTIME_DISTRIBUTION_COMPONENTS})
-      if(NOT "${target_name}:${target_name}-${component}" IN_LIST extra_targets)
-        list(APPEND ${name}_extra_targets
-          "${target_name}:${target_name}-${component}"
-          "${target_name}:${target_name}-install-${component}")
-      endif()
+      set(${component}-${name} ${component})
+      set(install-${component}-${name} ${component})
+      list(APPEND ${name}_extra_targets install-${component}-${name} ${component}-${name})
     endforeach()
 
     if(LLVM_INCLUDE_TESTS)
       set(runtimes-test-depends-${name} runtimes-test-depends)
       set(check-runtimes-${name} check-runtimes)
       list(APPEND ${name}_test_targets runtimes-test-depends-${name} check-runtimes-${name})
       foreach(target_name IN LISTS SUB_CHECK_TARGETS)
         set(${target_name}-${name} ${target_name})