Page MenuHomePhabricator

Revamp the "[clangd] Format tweak's replacements"
ClosedPublic

Authored by hokein on Mon, Feb 11, 5:42 AM.

Details

Summary

This patch contains two parts:

  1. reverts commit r353306.
  2. move the format logic out from tweaks, keep tweaks API unchanged.

Diff Detail

Event Timeline

hokein created this revision.Mon, Feb 11, 5:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Feb 11, 5:42 AM
hokein updated this revision to Diff 186239.Mon, Feb 11, 5:44 AM
  • [clangd] Re-submit format replacement for tweaks.
hokein retitled this revision from Revert "[clangd] Format tweak's replacements." to Revamp the "[clangd] Format tweak's replacements".Mon, Feb 11, 5:46 AM
hokein edited the summary of this revision. (Show Details)
hokein added reviewers: sammccall, ilya-biryukov.
ilya-biryukov accepted this revision.Mon, Feb 11, 6:45 AM

LGTM

clangd/ClangdServer.cpp
382

NIT: use InpAST.Inputs.FS instead of creating a new instance of the vfs.

This revision is now accepted and ready to land.Mon, Feb 11, 6:45 AM
hokein updated this revision to Diff 186246.Mon, Feb 11, 7:00 AM

Address review comment.

This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.