This is an archive of the discontinued LLVM Phabricator instance.

[GlobalISel] Skip patterns that define complex suboperands twice instead of dying
ClosedPublic

Authored by paquette on Feb 8 2019, 2:40 PM.

Details

Summary

If we run into a pattern that looks like this:

add
  (complex $x, $y)
  (complex $x, $z)

We should skip the pattern instead of asserting/doing something unpredictable. This makes us return an Error in that case, and adds a testcase for skipped patterns.

Patterns like this appear in some targets, so we can't really just die here. (See https://reviews.llvm.org/D57484).

Diff Detail

Event Timeline

paquette created this revision.Feb 8 2019, 2:40 PM
dsanders accepted this revision.Feb 8 2019, 4:19 PM

LGTM. Thanks for fixing this

This revision is now accepted and ready to land.Feb 8 2019, 4:19 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2019, 4:28 PM