This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Use Dex for dynamic index by default.
ClosedPublic

Authored by ioeric on Feb 7 2019, 1:17 AM.

Reviewers

sammccall
hokein

Commits

Summary

Memory usage for a sample TU:

Without Dex: 17.9M
With    Dex: 24.4M

The memory increase is considerable but seems tolerable.

(Just flipping the flag seems fine too)

This revision is now accepted and ready to land.Feb 7 2019, 7:24 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

clangd/

tool/

2 lines

	Show All 25 Lines
	#include <thread>			#include <thread>

	namespace clang {			namespace clang {
	namespace clangd {			namespace clangd {
	// FIXME: remove this option when Dex is cheap enough.			// FIXME: remove this option when Dex is cheap enough.
	static llvm::cl::opt<bool>			static llvm::cl::opt<bool>
	UseDex("use-dex-index",			UseDex("use-dex-index",
	llvm::cl::desc("Use experimental Dex dynamic index."),			llvm::cl::desc("Use experimental Dex dynamic index."),
	llvm::cl::init(false), llvm::cl::Hidden);			llvm::cl::init(true), llvm::cl::Hidden);

	static llvm::cl::opt<Path> CompileCommandsDir(			static llvm::cl::opt<Path> CompileCommandsDir(
	"compile-commands-dir",			"compile-commands-dir",
	llvm::cl::desc("Specify a path to look for compile_commands.json. If path "			llvm::cl::desc("Specify a path to look for compile_commands.json. If path "
	"is invalid, clangd will look in the current directory and "			"is invalid, clangd will look in the current directory and "
	"parent paths of each source file."));			"parent paths of each source file."));

	static llvm::cl::opt<unsigned>			static llvm::cl::opt<unsigned>
	▲ Show 20 Lines • Show All 425 Lines • Show Last 20 Lines