This is an archive of the discontinued LLVM Phabricator instance.

Differential D57873

[CMake] Mark runtime library link libraries as private
ClosedPublic

Authored by phosek on Feb 6 2019, 7:16 PM.

Details

Reviewers
morehouse
vitalybuka
smeenai
Commits
rG55a2fbe2342d: [CMake] Mark runtime library link libraries as private
rL353376: [CMake] Mark runtime library link libraries as private
rCRT353376: [CMake] Mark runtime library link libraries as private
Summary

There's no need to expose these dependencies to consumers. This
matches the change made to other runtimes in D57456.

Diff Detail

Event Timeline

phosek created this revision.Feb 6 2019, 7:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2019, 7:16 PM
Herald added subscribers: Restricted Project, mgorny. · View Herald Transcript
phosek added a child revision: D49587: [CMake] Support exporting runtimes using the CMake export.Feb 6 2019, 7:18 PM
smeenai accepted this revision.Feb 6 2019, 9:52 PM

LGTM

This revision is now accepted and ready to land.Feb 6 2019, 9:52 PM
Closed by commit rCRT353376: [CMake] Mark runtime library link libraries as private (authored by phosek). · Explain WhyFeb 6 2019, 10:31 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2019, 10:31 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
compiler-rt/
cmake/
Modules/
2 lines

Diff 185693

compiler-rt/cmake/Modules/AddCompilerRT.cmake

Show First 20 Lines • Show All 274 Lines • ▼ Show 20 Lines foreach(libname ${libnames})
set_target_link_flags(${libname} ${extra_link_flags_${libname}}) set_target_link_flags(${libname} ${extra_link_flags_${libname}})
set_property(TARGET ${libname} APPEND PROPERTY set_property(TARGET ${libname} APPEND PROPERTY
COMPILE_DEFINITIONS ${LIB_DEFS}) COMPILE_DEFINITIONS ${LIB_DEFS})
set_target_output_directories(${libname} ${output_dir_${libname}}) set_target_output_directories(${libname} ${output_dir_${libname}})
set_target_properties(${libname} PROPERTIES set_target_properties(${libname} PROPERTIES
OUTPUT_NAME ${output_name_${libname}}) OUTPUT_NAME ${output_name_${libname}})
set_target_properties(${libname} PROPERTIES FOLDER "Compiler-RT Runtime") set_target_properties(${libname} PROPERTIES FOLDER "Compiler-RT Runtime")
if(LIB_LINK_LIBS) if(LIB_LINK_LIBS)
target_link_libraries(${libname} ${LIB_LINK_LIBS}) target_link_libraries(${libname} PRIVATE ${LIB_LINK_LIBS})
endif() endif()
if(${type} STREQUAL "SHARED") if(${type} STREQUAL "SHARED")
if(COMMAND llvm_setup_rpath) if(COMMAND llvm_setup_rpath)
llvm_setup_rpath(${libname}) llvm_setup_rpath(${libname})
endif() endif()
if(WIN32 AND NOT CYGWIN AND NOT MINGW) if(WIN32 AND NOT CYGWIN AND NOT MINGW)
set_target_properties(${libname} PROPERTIES IMPORT_PREFIX "") set_target_properties(${libname} PROPERTIES IMPORT_PREFIX "")
set_target_properties(${libname} PROPERTIES IMPORT_SUFFIX ".lib") set_target_properties(${libname} PROPERTIES IMPORT_SUFFIX ".lib")
▲ Show 20 Lines • Show All 379 Lines • Show Last 20 Lines