This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Support runtimes and monorepo locations for tests
ClosedPublic

Authored by phosek on Feb 5 2019, 11:46 AM.

Details

Summary

The test configuration support currently searches for libc++ sources
in <ROOT>/projects/libcxx. This change also additionally searches
<ROOT>/runtimes/libcxx (so called runtimes layout) and <ROOT>/libcxx
(monorepo layout).

This matches the logic we already use in CMake, for example:
https://github.com/llvm/llvm-project/blob/6fd4e7f/libcxx/CMakeLists.txt#L148

When the monorepo becomes the only supported layout in the future,
we can simplify this logic again.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Feb 5 2019, 11:46 AM

After this and D57775 lands, together with all the lit and CMake changes that landed in the last few days, we'll be able to run libunwind, libc++abi and libc++ tests in the monorepo layout using the runtimes build with compiler-rt builtins and libunwind as the unwinder \o/

smeenai accepted this revision.Feb 8 2019, 5:46 PM
smeenai added a subscriber: smeenai.

LGTM

This revision is now accepted and ready to land.Feb 8 2019, 5:46 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2019, 6:50 PM