This is an archive of the discontinued LLVM Phabricator instance.

[opaque pointer types] Cleanup CGBuilder's Create*GEP.
ClosedPublic

Authored by jyknight on Feb 5 2019, 9:31 AM.

Details

Summary

The various EltSize, Offset, DataLayout, and StructLayout arguments
are all computable from the Address's element type and the DataLayout
which the CGBuilder already has access to.

After having previously asserted that the computed values are the same
as those passed in, now remove the redundant arguments from
CGBuilder's Create*GEP functions.

Event Timeline

jyknight created this revision.Feb 5 2019, 9:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2019, 9:31 AM
dblaikie accepted this revision.Feb 5 2019, 4:09 PM

Great!

This revision is now accepted and ready to land.Feb 5 2019, 4:09 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2019, 2:22 PM