This is an archive of the discontinued LLVM Phabricator instance.

Differential D57631

[COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail
ClosedPublic

Authored by TomTan on Feb 1 2019, 4:43 PM.

Details

Reviewers
rnk
mstorsjo
efriedma
Commits
rGdcb9e08fae43: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail
rC353337: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail
rL353337: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail
Summary

The MSDN document was also updated to reflect this, but it probably will take a few days to show in below link.

https://docs.microsoft.com/en-us/cpp/intrinsics/fastfail

Diff Detail

Event Timeline

TomTan created this revision.Feb 1 2019, 4:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2019, 4:43 PM
Herald added subscribers: cfe-commits, kristof.beyls. · View Herald Transcript
efriedma accepted this revision.Feb 1 2019, 4:58 PM

LGTM

This revision is now accepted and ready to land.Feb 1 2019, 4:58 PM
TomTan added a comment.Feb 4 2019, 12:05 PM
In D57631#1381806, @efriedma wrote:

LGTM

Thanks Eli. Could you please help commit this change when it is ready?

Closed by commit rL353337: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail (authored by TomTan). · Explain WhyFeb 6 2019, 12:08 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2019, 12:08 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
lib/
CodeGen/
3 lines
test/
CodeGen/
5 lines

Diff 184869

lib/CodeGen/CGBuiltin.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 989 Lines • ▼ Show 20 Lines case MSVCIntrin::__fastfail: {
case llvm::Triple::x86_64: case llvm::Triple::x86_64:
Asm = "int $$0x29"; Asm = "int $$0x29";
Constraints = "{cx}"; Constraints = "{cx}";
break; break;
case llvm::Triple::thumb: case llvm::Triple::thumb:
Asm = "udf #251"; Asm = "udf #251";
Constraints = "{r0}"; Constraints = "{r0}";
break; break;
case llvm::Triple::aarch64:
Asm = "brk #0xF003";
Constraints = "{w0}";
} }
llvm::FunctionType *FTy = llvm::FunctionType::get(VoidTy, {Int32Ty}, false); llvm::FunctionType *FTy = llvm::FunctionType::get(VoidTy, {Int32Ty}, false);
llvm::InlineAsm *IA = llvm::InlineAsm *IA =
llvm::InlineAsm::get(FTy, Asm, Constraints, /*SideEffects=*/true); llvm::InlineAsm::get(FTy, Asm, Constraints, /*SideEffects=*/true);
llvm::AttributeList NoReturnAttr = llvm::AttributeList::get( llvm::AttributeList NoReturnAttr = llvm::AttributeList::get(
getLLVMContext(), llvm::AttributeList::FunctionIndex, getLLVMContext(), llvm::AttributeList::FunctionIndex,
llvm::Attribute::NoReturn); llvm::Attribute::NoReturn);
CallSite CS = Builder.CreateCall(IA, EmitScalarExpr(E->getArg(0))); CallSite CS = Builder.CreateCall(IA, EmitScalarExpr(E->getArg(0)));
▲ Show 20 Lines • Show All 9,991 Lines • Show Last 20 Lines

test/CodeGen/ms-intrinsics.c

// RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility -fms-compatibility-version=17.00 \ // RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility -fms-compatibility-version=17.00 \
// RUN: -triple i686--windows -Oz -emit-llvm %s -o - \ // RUN: -triple i686--windows -Oz -emit-llvm %s -o - \
// RUN: | FileCheck %s -check-prefixes CHECK,CHECK-I386,CHECK-INTEL // RUN: | FileCheck %s -check-prefixes CHECK,CHECK-I386,CHECK-INTEL
// RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility -fms-compatibility-version=17.00 \ // RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility -fms-compatibility-version=17.00 \
// RUN: -triple thumbv7--windows -Oz -emit-llvm %s -o - \ // RUN: -triple thumbv7--windows -Oz -emit-llvm %s -o - \
// RUN: | FileCheck %s --check-prefixes CHECK,CHECK-ARM,CHECK-ARM-ARM64,CHECK-ARM-X64 // RUN: | FileCheck %s --check-prefixes CHECK,CHECK-ARM,CHECK-ARM-ARM64,CHECK-ARM-X64
// RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility -fms-compatibility-version=17.00 \ // RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility -fms-compatibility-version=17.00 \
// RUN: -triple x86_64--windows -Oz -emit-llvm -target-feature +cx16 %s -o - \ // RUN: -triple x86_64--windows -Oz -emit-llvm -target-feature +cx16 %s -o - \
// RUN: | FileCheck %s --check-prefixes CHECK,CHECK-X64,CHECK-ARM-X64,CHECK-INTEL // RUN: | FileCheck %s --check-prefixes CHECK,CHECK-X64,CHECK-ARM-X64,CHECK-INTEL
// RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility -fms-compatibility-version=17.00 \ // RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility -fms-compatibility-version=17.00 \
// RUN: -triple aarch64-windows -Oz -emit-llvm %s -o - \ // RUN: -triple aarch64-windows -Oz -emit-llvm %s -o - \
// RUN: | FileCheck %s --check-prefixes CHECK-ARM-ARM64,CHECK-ARM-X64 // RUN: | FileCheck %s --check-prefixes CHECK-ARM-ARM64,CHECK-ARM-X64,CHECK-ARM64
// intrin.h needs size_t, but -ffreestanding prevents us from getting it from // intrin.h needs size_t, but -ffreestanding prevents us from getting it from
// stddef.h. Work around it with this typedef. // stddef.h. Work around it with this typedef.
typedef __SIZE_TYPE__ size_t; typedef __SIZE_TYPE__ size_t;
#include <intrin.h> #include <intrin.h>
#if defined(__i386__) || defined(__x86_64__) #if defined(__i386__) || defined(__x86_64__)
▲ Show 20 Lines • Show All 1,316 Lines • ▼ Show 20 Lines
} }
// CHECK-ARM-ARM64: define{{.*}}i64 @test_InterlockedDecrement64_nf(i64*{{[a-z_ ]*}}%Addend){{.*}}{ // CHECK-ARM-ARM64: define{{.*}}i64 @test_InterlockedDecrement64_nf(i64*{{[a-z_ ]*}}%Addend){{.*}}{
// CHECK-ARM-ARM64: [[TMP:%[0-9]+]] = atomicrmw sub i64* %Addend, i64 1 monotonic // CHECK-ARM-ARM64: [[TMP:%[0-9]+]] = atomicrmw sub i64* %Addend, i64 1 monotonic
// CHECK-ARM-ARM64: [[RESULT:%[0-9]+]] = add i64 [[TMP]], -1 // CHECK-ARM-ARM64: [[RESULT:%[0-9]+]] = add i64 [[TMP]], -1
// CHECK-ARM-ARM64: ret i64 [[RESULT]] // CHECK-ARM-ARM64: ret i64 [[RESULT]]
// CHECK-ARM-ARM64: } // CHECK-ARM-ARM64: }
#endif #endif
#if !defined(__aarch64__)
void test__fastfail() { void test__fastfail() {
__fastfail(42); __fastfail(42);
} }
// CHECK-LABEL: define{{.*}} void @test__fastfail() // CHECK-LABEL: define{{.*}} void @test__fastfail()
// CHECK-ARM: call void asm sideeffect "udf #251", "{r0}"(i32 42) #[[NORETURN:[0-9]+]] // CHECK-ARM: call void asm sideeffect "udf #251", "{r0}"(i32 42) #[[NORETURN:[0-9]+]]
// CHECK-INTEL: call void asm sideeffect "int $$0x29", "{cx}"(i32 42) #[[NORETURN]] // CHECK-INTEL: call void asm sideeffect "int $$0x29", "{cx}"(i32 42) #[[NORETURN]]
// CHECK-ARM64: call void asm sideeffect "brk #0xF003", "{w0}"(i32 42) #[[NORETURN:[0-9]+]]
// Attributes come last. // Attributes come last.
// CHECK: attributes #[[NORETURN]] = { noreturn{{.*}} } // CHECK: attributes #[[NORETURN]] = { noreturn{{.*}} }
#endif