This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy][NFC] Use StringSaver for --keep-global-symbols
ClosedPublic

Authored by rupprecht on Feb 1 2019, 2:04 PM.

Details

Summary

Use StringSaver/BumpPtrAlloc when parsing lines from --keep-global-symbols files. This allows us to consistently use StringRef for driver options, which avoids copying the full strings for each object copied, as well as simplifies part of D57517.

Event Timeline

rupprecht created this revision.Feb 1 2019, 2:04 PM
This revision is now accepted and ready to land.Feb 3 2019, 11:45 PM
This revision was automatically updated to reflect the committed changes.