This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Ensure BasicSymbolRef.getRawDataRefImpl().p is non-null
ClosedPublic

Authored by sbc100 on Jan 28 2019, 11:03 PM.

Details

Summary

Store a non-zero value to ref.d.a and use ref.d.b to store the symbol
index. This means that ref.p is never null, which was confusing
llvm-nm.

Fixes PR40497

Diff Detail

Event Timeline

sbc100 created this revision.Jan 28 2019, 11:03 PM
sbc100 updated this revision to Diff 184159.Jan 29 2019, 12:56 PM
  • fix comment
sbc100 updated this revision to Diff 184160.Jan 29 2019, 1:05 PM
  • update tests
tlively accepted this revision.Jan 29 2019, 2:06 PM

I have no idea what Ref.d.a or Ref.d.b are, but that is just as true before this CL.

This revision is now accepted and ready to land.Jan 29 2019, 2:06 PM
This revision was automatically updated to reflect the committed changes.