Page MenuHomePhabricator

[analyzer] [RetainCountChecker] Track input parameters to the top-level function
ClosedPublic

Authored by george.karpenkov on Jan 28 2019, 1:41 PM.

Diff Detail

Event Timeline

NoQ accepted this revision.Jan 28 2019, 3:02 PM

I just fail to understand why nobody did that before. As far as i understand, that's a very large improvement.

clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp
713

This looks out-of-place here.

clang/test/Analysis/osobject-retain-release.cpp
63

// no-note?

This revision is now accepted and ready to land.Jan 28 2019, 3:02 PM

I just fail to understand why nobody did that before. As far as i understand, that's a very large improvement.

I think because it required D57346 and all the AnyCall machinery.

NoQ added a comment.Jan 28 2019, 5:39 PM

I just fail to understand why nobody did that before. As far as i understand, that's a very large improvement.

I think because it required D57346 and all the AnyCall machinery.

Heh. Indeed. Then it sounds like yet another great example of why cleaner code matters.

This revision was automatically updated to reflect the committed changes.