[analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager
ClosedPublic
Actions

Authored by george.karpenkov on Jan 28 2019, 11:18 AM.

Details

Reviewers

dcoughlin
NoQ

Commits

rG2e466678536f: [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager
rL352532: [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager
rC352532: [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager

Summary

Just use one single entry point, since we have AnyCall utility now.

Diff Detail

Repository: rC Clang

Event Timeline

george.karpenkov created this revision.Jan 28 2019, 11:18 AM

Herald added subscribers: dkrupp, donat.nagy, Szelethus and 5 others. · View Herald TranscriptJan 28 2019, 11:18 AM

george.karpenkov added a parent revision: D57344: Extend AnyCall to handle callable declarations without the call expressions.Jan 28 2019, 11:18 AM

george.karpenkov retitled this revision from [analyzer] [ARCMT] Unify entry point into RetainSummaryManager to [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager.

Hmm. Yeah, this looks unused :)

This revision is now accepted and ready to land.Jan 28 2019, 2:51 PM

george.karpenkov added a child revision: D57356: [analyzer] [RetainCountChecker] Track input parameters to the top-level function.Jan 28 2019, 3:36 PM

george.karpenkov mentioned this in D57356: [analyzer] [RetainCountChecker] Track input parameters to the top-level function.

Closed by commit rC352532: [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager (authored by george.karpenkov, committed by ). · Explain WhyJan 29 2019, 11:29 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: cfe-commits. · View Herald TranscriptJan 29 2019, 11:29 AM

Revision Contents
Changeset List

			Path	Packages
M			include/clang/Analysis/RetainSummaryManager.h (47 lines)
M			lib/ARCMigrate/ObjCMT.cpp (57 lines)
M			lib/Analysis/RetainSummaryManager.cpp (37 lines)
M			lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	183916			Jan 28 2019, 11:17 AM	★	★
Diff 2	184139	352531	rC352532	Jan 29 2019, 11:29 AM	★	★

Status	Author	Revision
Closed	george.karpenkov	D57356 [analyzer] [RetainCountChecker] Track input parameters to the top-level function
Closed	george.karpenkov	D57346 [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager
Closed	george.karpenkov	D57344 Extend AnyCall to handle callable declarations without the call expressions