Track them for ISL/OS objects by default, and for NS/CF under a flag.
rdar://47536377
Paths
| Differential D57356
[analyzer] [RetainCountChecker] Track input parameters to the top-level function ClosedPublic Authored by george.karpenkov on Jan 28 2019, 1:41 PM.
Details
Summary Track them for ISL/OS objects by default, and for NS/CF under a flag. rdar://47536377
Diff Detail
Event TimelineHerald added subscribers: dkrupp, donat.nagy, Szelethus and 5 others. · View Herald TranscriptJan 28 2019, 1:41 PM Comment Actions I just fail to understand why nobody did that before. As far as i understand, that's a very large improvement.
This revision is now accepted and ready to land.Jan 28 2019, 3:02 PM george.karpenkov added a parent revision: D57346: [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager.Jan 28 2019, 3:36 PM Comment Actions
I think because it required D57346 and all the AnyCall machinery. Comment Actions
Heh. Indeed. Then it sounds like yet another great example of why cleaner code matters. Closed by commit rL352534: [analyzer] [RetainCountChecker] Track input parameters to the top-level function (authored by george.karpenkov). · Explain WhyJan 29 2019, 11:30 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 184141 cfe/trunk/include/clang/Analysis/RetainSummaryManager.h
cfe/trunk/lib/Analysis/RetainSummaryManager.cpp
cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.h
cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp
cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp
cfe/trunk/test/Analysis/Inputs/expected-plists/retain-release.m.objc.plist
cfe/trunk/test/Analysis/Inputs/expected-plists/retain-release.m.objcpp.plist
cfe/trunk/test/Analysis/osobject-retain-release.cpp
cfe/trunk/test/Analysis/retain-release.m
|