This is an archive of the discontinued LLVM Phabricator instance.

Differential D57329

[gn] Checking in BUILD.gn files for clang-tidy and clang-apply-replacements
ClosedPublic

Authored by mbonadei on Jan 28 2019, 7:48 AM.

Details

Reviewers
thakis
yvesg
Commits
rG50be01149cd8: gn build: BUILD.gn files for clang-tidy and clang-apply-replacements
rL353177: gn build: BUILD.gn files for clang-tidy and clang-apply-replacements

Diff Detail

Event Timeline

mbonadei created this revision.Jan 28 2019, 7:48 AM
Herald added subscribers: llvm-commits, kbarton, nemanjai, srhines. · View Herald TranscriptJan 28 2019, 7:48 AM
yvesg accepted this revision.Feb 1 2019, 10:47 AM
yvesg added a subscriber: yvesg.

Nice, LGTM!

llvm/utils/gn/build/BUILD.gn
152

I'm surprised there is a config for this, but not for clang-tidy itself. Why is that so?

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
19

What should be fixed? I.e. what is the current limitation?
Static Analyzer checks not available? If so, the following deps could be commented.

This revision is now accepted and ready to land.Feb 1 2019, 10:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2019, 10:47 AM
thakis added a comment.Feb 1 2019, 11:56 AM

(Please give me a few more days too. Sorry it's taking so long, have been firefighting all week :-/)

mbonadei added a comment.Feb 4 2019, 5:17 AM
In D57329#1381267, @thakis wrote:

(Please give me a few more days too. Sorry it's taking so long, have been firefighting all week :-/)

No worries. It is not urgent, I am also a bit swamped over here too. I will get back to this in a couple of days.

thakis added a comment.Feb 4 2019, 10:42 AM

Thanks, this is great!

llvm/utils/gn/build/BUILD.gn
152

I think we should remove this and instead put include_dirs = [ "include" ] and include_dirs = [ "../include" ] respectively in the two clang-apply-replacement build files instead. I think the clang-extra-tools stuff is intended to look like tools in llvm/tools or clang/tools and not like a full lib, and clang-apply-replacements is just weird in doing this full include and lib subtree thing for what is effectively 3 files.

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
19

+1.

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/abseil/BUILD.gn
14

Because it took me so long, this is now missing

"DurationAdditionCheck.cpp",

(courtesy of llvm/utils/gn/build/sync_source_lists_from_cmake.py after rebasing locally)

llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn
3

Instead of this, I think it'd be better to say configs += [ "//llvm/utils/gn/build:clang_code" ] in all the clang-tools-extra targets (like all the clang targets do)

mbonadei updated this revision to Diff 185295.Feb 5 2019, 6:24 AM
mbonadei marked 7 inline comments as done.
mbonadei added inline comments.
llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
19

I commented out the two deps below. I will look into it in the next few days (ClangSACheckers uses tablegen and I need to read about it and learn what it does). Is it OK to land this without SACheckers support?

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/abseil/BUILD.gn
14

That script is great! It detected two more checks that have been added recently! :)

llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn
3

I see that we are not declaring headers to gn. Is this something we'll want to have in the future? I think this is related to how we look at configs vs public_configs as well.

thakis accepted this revision.Feb 5 2019, 6:56 AM

lgtm!

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
19

Sure, that's fine. (git grep tablegen llvm/utils/gn will show you lots of tablegen examples if you want to tackle these later.)

llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn
3

Maybe; it's the gn check item in llvm/utils/gn/TODO.txt.

mbonadei marked an inline comment as done.Feb 5 2019, 7:10 AM
mbonadei added inline comments.
llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
19

Sure, I will do it! Thanks!

mbonadei added a comment.Feb 5 2019, 7:11 AM

I don't have commit access. Can you take care of landing this one?

Closed by commit rL353177: gn build: BUILD.gn files for clang-tidy and clang-apply-replacements (authored by nico). · Explain WhyFeb 5 2019, 7:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
utils/
gn/
build/
8 lines
secondary/
2 lines
clang-tools-extra/
clang-apply-replacements/
14 lines
tool/
15 lines
clang-tidy/
37 lines
abseil/
30 lines
android/
29 lines
boost/
16 lines
bugprone/
58 lines
cert/
30 lines
cppcoreguidelines/
38 lines
fuchsia/
23 lines
google/
31 lines
hicpp/
27 lines
llvm/
20 lines
misc/
31 lines
modernize/
48 lines
mpi/
20 lines
objc/
19 lines
performance/
28 lines
plugin/
37 lines
portability/
17 lines
readability/
49 lines
tool/
39 lines
utils/
26 lines
zircon/
16 lines
clang/
lib/
Basic/
2 lines
llvm/
utils/
TableGen/
2 lines

Diff 183860

llvm/utils/gn/build/BUILD.gn

Show First 20 Lines • Show All 143 Lines • ▼ Show 20 Lines
config("lld_code") { config("lld_code") {
include_dirs = [ include_dirs = [
"//lld/include", "//lld/include",
"$root_gen_dir/lld/include", "$root_gen_dir/lld/include",
] ]
} }
config("clang_apply_replacements_code") {
yvesgUnsubmitted
Done
ReplyInline Actions

I'm surprised there is a config for this, but not for clang-tidy itself. Why is that so?

yvesg: I'm surprised there is a config for this, but not for clang-tidy itself. Why is that so?
thakisUnsubmitted
Done
ReplyInline Actions

I think we should remove this and instead put include_dirs = [ "include" ] and include_dirs = [ "../include" ] respectively in the two clang-apply-replacement build files instead. I think the clang-extra-tools stuff is intended to look like tools in llvm/tools or clang/tools and not like a full lib, and clang-apply-replacements is just weird in doing this full include and lib subtree thing for what is effectively 3 files.

thakis: I think we should remove this and instead put ` include_dirs = [ "include" ]` and `…
include_dirs = [
"//clang-tools-extra/clang-apply-replacements/include",
"$root_gen_dir/clang-apply-replacements/include",
]
configs = [ ":llvm_code" ]
}
config("clang_code") { config("clang_code") {
if (host_os != "win") { if (host_os != "win") {
cflags = [ "-fno-strict-aliasing" ] cflags = [ "-fno-strict-aliasing" ]
} }
include_dirs = [ include_dirs = [
"//clang/include", "//clang/include",
"$root_gen_dir/clang/include", "$root_gen_dir/clang/include",
] ]
Show All 16 Lines

llvm/utils/gn/secondary/BUILD.gn

import("//clang/lib/ARCMigrate/enable.gni") import("//clang/lib/ARCMigrate/enable.gni")
import("//clang/lib/StaticAnalyzer/Frontend/enable.gni") import("//clang/lib/StaticAnalyzer/Frontend/enable.gni")
import("//llvm/utils/gn/build/toolchain/compiler.gni") import("//llvm/utils/gn/build/toolchain/compiler.gni")
group("default") { group("default") {
deps = [ deps = [
"//clang-tools-extra/clang-apply-replacements/tool:clang-apply-replacements",
"//clang-tools-extra/clang-tidy/tool:clang-tidy",
"//clang/test", "//clang/test",
"//lld/test", "//lld/test",
"//llvm/test", "//llvm/test",
] ]
if (current_os == "linux" || current_os == "android") { if (current_os == "linux" || current_os == "android") {
deps += [ "//compiler-rt/test/hwasan" ] deps += [ "//compiler-rt/test/hwasan" ]
} }
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines

llvm/utils/gn/secondary/clang-tools-extra/clang-apply-replacements/BUILD.gn

  • This file was added.
static_library("clang-apply-replacements") {
configs += [ "//llvm/utils/gn/build:clang_apply_replacements_code" ]
deps = [
"//clang/lib/AST",
"//clang/lib/Basic",
"//clang/lib/Rewrite",
"//clang/lib/Tooling/Core",
"//clang/lib/Tooling/Refactoring",
"//llvm/lib/Support",
]
sources = [
"lib/Tooling/ApplyReplacements.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-apply-replacements/tool/BUILD.gn

  • This file was added.
executable("clang-apply-replacements") {
configs += [ "//llvm/utils/gn/build:clang_apply_replacements_code" ]
deps = [
"//clang-tools-extra/clang-apply-replacements",
"//clang/lib/Basic",
"//clang/lib/Format",
"//clang/lib/Rewrite",
"//clang/lib/Tooling/Core",
"//clang/lib/Tooling/Refactoring",
"//llvm/lib/Support",
]
sources = [
"ClangApplyReplacementsMain.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn

  • This file was added.
import("//clang/lib/StaticAnalyzer/Frontend/enable.gni")
static_library("clang-tidy") {
output_name = "clangTidy"
deps = [
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Format",
"//clang/lib/Frontend",
"//clang/lib/Lex",
"//clang/lib/Rewrite",
"//clang/lib/Sema",
"//clang/lib/Serialization",
"//clang/lib/Tooling",
"//clang/lib/Tooling/Core",
"//llvm/lib/Support",
# TODO(mbonadei): FIXME.
yvesgUnsubmitted
Not Done
ReplyInline Actions

What should be fixed? I.e. what is the current limitation?
Static Analyzer checks not available? If so, the following deps could be commented.

yvesg: What should be fixed? I.e. what is the current limitation? Static Analyzer checks not available?
thakisUnsubmitted
Not Done
ReplyInline Actions

+1.

thakis: +1.
mbonadeiAuthorUnsubmitted
Done
ReplyInline Actions

I commented out the two deps below. I will look into it in the next few days (ClangSACheckers uses tablegen and I need to read about it and learn what it does). Is it OK to land this without SACheckers support?

mbonadei: I commented out the two deps below. I will look into it in the next few days (ClangSACheckers…
thakisUnsubmitted
Not Done
ReplyInline Actions

Sure, that's fine. (git grep tablegen llvm/utils/gn will show you lots of tablegen examples if you want to tackle these later.)

thakis: Sure, that's fine. (`git grep tablegen llvm/utils/gn` will show you lots of tablegen examples…
mbonadeiAuthorUnsubmitted
Done
ReplyInline Actions

Sure, I will do it! Thanks!

mbonadei: Sure, I will do it! Thanks!
# ClangSACheckers
]
if (clang_enable_static_analyzer) {
deps += [
"//clang/lib/StaticAnalyzer/Core",
"//clang/lib/StaticAnalyzer/Frontend",
]
}
sources = [
"ClangTidy.cpp",
"ClangTidyDiagnosticConsumer.cpp",
"ClangTidyModule.cpp",
"ClangTidyOptions.cpp",
"ClangTidyProfiling.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/abseil/BUILD.gn

  • This file was added.
static_library("abseil") {
output_name = "clangTidyAbseilModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//clang/lib/Tooling",
"//llvm/lib/Support",
]
sources = [
"AbseilTidyModule.cpp",
thakisUnsubmitted
Done
ReplyInline Actions

Because it took me so long, this is now missing

"DurationAdditionCheck.cpp",

(courtesy of llvm/utils/gn/build/sync_source_lists_from_cmake.py after rebasing locally)

thakis: Because it took me so long, this is now missing "DurationAdditionCheck.cpp", (courtesy of…
mbonadeiAuthorUnsubmitted
Done
ReplyInline Actions

That script is great! It detected two more checks that have been added recently! :)

mbonadei: That script is great! It detected two more checks that have been added recently! :)
"DurationComparisonCheck.cpp",
"DurationConversionCastCheck.cpp",
"DurationDivisionCheck.cpp",
"DurationFactoryFloatCheck.cpp",
"DurationFactoryScaleCheck.cpp",
"DurationRewriter.cpp",
"DurationSubtractionCheck.cpp",
"FasterStrsplitDelimiterCheck.cpp",
"NoInternalDependenciesCheck.cpp",
"NoNamespaceCheck.cpp",
"RedundantStrcatCallsCheck.cpp",
"StrCatAppendCheck.cpp",
"StringFindStartswithCheck.cpp",
"UpgradeDurationConversionsCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/android/BUILD.gn

  • This file was added.
static_library("android") {
output_name = "clangTidyAndroidModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//llvm/lib/Support",
]
sources = [
"AndroidTidyModule.cpp",
"CloexecAccept4Check.cpp",
"CloexecAcceptCheck.cpp",
"CloexecCheck.cpp",
"CloexecCreatCheck.cpp",
"CloexecDupCheck.cpp",
"CloexecEpollCreate1Check.cpp",
"CloexecEpollCreateCheck.cpp",
"CloexecFopenCheck.cpp",
"CloexecInotifyInit1Check.cpp",
"CloexecInotifyInitCheck.cpp",
"CloexecMemfdCreateCheck.cpp",
"CloexecOpenCheck.cpp",
"CloexecSocketCheck.cpp",
"ComparisonInTempFailureRetryCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/boost/BUILD.gn

  • This file was added.
static_library("boost") {
output_name = "clangTidyBoostModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//llvm/lib/Support",
]
sources = [
"BoostTidyModule.cpp",
"UseToStringCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/bugprone/BUILD.gn

  • This file was added.
static_library("bugprone") {
output_name = "clangTidyBugproneModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/cppcoreguidelines",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Analysis",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//clang/lib/Tooling",
"//llvm/lib/Support",
]
sources = [
"ArgumentCommentCheck.cpp",
"AssertSideEffectCheck.cpp",
"BoolPointerImplicitConversionCheck.cpp",
"BugproneTidyModule.cpp",
"CopyConstructorInitCheck.cpp",
"DanglingHandleCheck.cpp",
"ExceptionEscapeCheck.cpp",
"FoldInitTypeCheck.cpp",
"ForwardDeclarationNamespaceCheck.cpp",
"ForwardingReferenceOverloadCheck.cpp",
"InaccurateEraseCheck.cpp",
"IncorrectRoundingsCheck.cpp",
"IntegerDivisionCheck.cpp",
"LambdaFunctionNameCheck.cpp",
"MacroParenthesesCheck.cpp",
"MacroRepeatedSideEffectsCheck.cpp",
"MisplacedOperatorInStrlenInAllocCheck.cpp",
"MisplacedWideningCastCheck.cpp",
"MoveForwardingReferenceCheck.cpp",
"MultipleStatementMacroCheck.cpp",
"ParentVirtualCallCheck.cpp",
"SizeofContainerCheck.cpp",
"SizeofExpressionCheck.cpp",
"StringConstructorCheck.cpp",
"StringIntegerAssignmentCheck.cpp",
"StringLiteralWithEmbeddedNulCheck.cpp",
"SuspiciousEnumUsageCheck.cpp",
"SuspiciousMemsetUsageCheck.cpp",
"SuspiciousMissingCommaCheck.cpp",
"SuspiciousSemicolonCheck.cpp",
"SuspiciousStringCompareCheck.cpp",
"SwappedArgumentsCheck.cpp",
"TerminatingContinueCheck.cpp",
"ThrowKeywordMissingCheck.cpp",
"TooSmallLoopVariableCheck.cpp",
"UndefinedMemoryManipulationCheck.cpp",
"UndelegatedConstructorCheck.cpp",
"UnusedRaiiCheck.cpp",
"UnusedReturnValueCheck.cpp",
"UseAfterMoveCheck.cpp",
"VirtualNearMissCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/cert/BUILD.gn

  • This file was added.
static_library("cert") {
output_name = "clangTidyCERTModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/google",
"//clang-tools-extra/clang-tidy/misc",
"//clang-tools-extra/clang-tidy/performance",
"//clang-tools-extra/clang-tidy/readability",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//llvm/lib/Support",
]
sources = [
"CERTTidyModule.cpp",
"CommandProcessorCheck.cpp",
"DontModifyStdNamespaceCheck.cpp",
"FloatLoopCounter.cpp",
"LimitedRandomnessCheck.cpp",
"PostfixOperatorCheck.cpp",
"ProperlySeededRandomGeneratorCheck.cpp",
"SetLongJmpCheck.cpp",
"StaticObjectExceptionCheck.cpp",
"StrToNumCheck.cpp",
"ThrownExceptionTypeCheck.cpp",
"VariadicFunctionDefCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/cppcoreguidelines/BUILD.gn

  • This file was added.
static_library("cppcoreguidelines") {
output_name = "clangTidyCppCoreGuidelinesModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/misc",
"//clang-tools-extra/clang-tidy/modernize",
"//clang-tools-extra/clang-tidy/readability",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//clang/lib/Serialization",
"//clang/lib/Tooling",
"//llvm/lib/Support",
]
sources = [
"AvoidGotoCheck.cpp",
"CppCoreGuidelinesTidyModule.cpp",
"InterfacesGlobalInitCheck.cpp",
"MacroUsageCheck.cpp",
"NarrowingConversionsCheck.cpp",
"NoMallocCheck.cpp",
"OwningMemoryCheck.cpp",
"ProBoundsArrayToPointerDecayCheck.cpp",
"ProBoundsConstantArrayIndexCheck.cpp",
"ProBoundsPointerArithmeticCheck.cpp",
"ProTypeConstCastCheck.cpp",
"ProTypeCstyleCastCheck.cpp",
"ProTypeMemberInitCheck.cpp",
"ProTypeReinterpretCastCheck.cpp",
"ProTypeStaticCastDowncastCheck.cpp",
"ProTypeUnionAccessCheck.cpp",
"ProTypeVarargCheck.cpp",
"SlicingCheck.cpp",
"SpecialMemberFunctionsCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/fuchsia/BUILD.gn

  • This file was added.
static_library("fuchsia") {
output_name = "clangTidyFuchsiaModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/google",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//llvm/lib/Support",
]
sources = [
"DefaultArgumentsCheck.cpp",
"FuchsiaTidyModule.cpp",
"MultipleInheritanceCheck.cpp",
"OverloadedOperatorCheck.cpp",
"RestrictSystemIncludesCheck.cpp",
"StaticallyConstructedObjectsCheck.cpp",
"TrailingReturnCheck.cpp",
"VirtualInheritanceCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/google/BUILD.gn

  • This file was added.
static_library("google") {
output_name = "clangTidyGoogleModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/readability",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//llvm/lib/Support",
]
sources = [
"AvoidCStyleCastsCheck.cpp",
"AvoidThrowingObjCExceptionCheck.cpp",
"AvoidUnderscoreInGoogletestNameCheck.cpp",
"DefaultArgumentsCheck.cpp",
"ExplicitConstructorCheck.cpp",
"ExplicitMakePairCheck.cpp",
"FunctionNamingCheck.cpp",
"GlobalNamesInHeadersCheck.cpp",
"GlobalVariableDeclarationCheck.cpp",
"GoogleTidyModule.cpp",
"IntegerTypesCheck.cpp",
"NonConstReferences.cpp",
"OverloadedUnaryAndCheck.cpp",
"TodoCommentCheck.cpp",
"UnnamedNamespaceInHeaderCheck.cpp",
"UsingNamespaceDirectiveCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/hicpp/BUILD.gn

  • This file was added.
static_library("hicpp") {
output_name = "clangTidyHICPPModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/bugprone",
"//clang-tools-extra/clang-tidy/cppcoreguidelines",
"//clang-tools-extra/clang-tidy/google",
"//clang-tools-extra/clang-tidy/misc",
"//clang-tools-extra/clang-tidy/modernize",
"//clang-tools-extra/clang-tidy/performance",
"//clang-tools-extra/clang-tidy/readability",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//clang/lib/Serialization",
"//llvm/lib/Support",
]
sources = [
"ExceptionBaseclassCheck.cpp",
"HICPPTidyModule.cpp",
"MultiwayPathsCoveredCheck.cpp",
"NoAssemblerCheck.cpp",
"SignedBitwiseCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/llvm/BUILD.gn

  • This file was added.
static_library("llvm") {
output_name = "clangTidyLLVMModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/readability",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//clang/lib/Tooling",
"//llvm/lib/Support",
]
sources = [
"HeaderGuardCheck.cpp",
"IncludeOrderCheck.cpp",
"LLVMTidyModule.cpp",
"TwineLocalCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/misc/BUILD.gn

  • This file was added.
static_library("misc") {
output_name = "clangTidyMiscModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Analysis",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//clang/lib/Serialization",
"//clang/lib/Tooling",
"//llvm/lib/Support",
]
sources = [
"DefinitionsInHeadersCheck.cpp",
"MiscTidyModule.cpp",
"MisplacedConstCheck.cpp",
"NewDeleteOverloadsCheck.cpp",
"NonCopyableObjects.cpp",
"NonPrivateMemberVariablesInClassesCheck.cpp",
"RedundantExpressionCheck.cpp",
"StaticAssertCheck.cpp",
"ThrowByValueCatchByReferenceCheck.cpp",
"UnconventionalAssignOperatorCheck.cpp",
"UniqueptrResetReleaseCheck.cpp",
"UnusedAliasDeclsCheck.cpp",
"UnusedParametersCheck.cpp",
"UnusedUsingDeclsCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/modernize/BUILD.gn

  • This file was added.
static_library("modernize") {
output_name = "clangTidyModernizeModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/readability",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//clang/lib/Tooling",
"//llvm/lib/Support",
]
sources = [
"AvoidBindCheck.cpp",
"AvoidCArraysCheck.cpp",
"ConcatNestedNamespacesCheck.cpp",
"DeprecatedHeadersCheck.cpp",
"DeprecatedIosBaseAliasesCheck.cpp",
"LoopConvertCheck.cpp",
"LoopConvertUtils.cpp",
"MakeSharedCheck.cpp",
"MakeSmartPtrCheck.cpp",
"MakeUniqueCheck.cpp",
"ModernizeTidyModule.cpp",
"PassByValueCheck.cpp",
"RawStringLiteralCheck.cpp",
"RedundantVoidArgCheck.cpp",
"ReplaceAutoPtrCheck.cpp",
"ReplaceRandomShuffleCheck.cpp",
"ReturnBracedInitListCheck.cpp",
"ShrinkToFitCheck.cpp",
"UnaryStaticAssertCheck.cpp",
"UseAutoCheck.cpp",
"UseBoolLiteralsCheck.cpp",
"UseDefaultMemberInitCheck.cpp",
"UseEmplaceCheck.cpp",
"UseEqualsDefaultCheck.cpp",
"UseEqualsDeleteCheck.cpp",
"UseNodiscardCheck.cpp",
"UseNoexceptCheck.cpp",
"UseNullptrCheck.cpp",
"UseOverrideCheck.cpp",
"UseTransparentFunctorsCheck.cpp",
"UseUncaughtExceptionsCheck.cpp",
"UseUsingCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/mpi/BUILD.gn

  • This file was added.
static_library("mpi") {
output_name = "clangTidyMPIModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Analysis",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//clang/lib/StaticAnalyzer/Checkers",
"//clang/lib/Tooling",
"//llvm/lib/Support",
]
sources = [
"BufferDerefCheck.cpp",
"MPITidyModule.cpp",
"TypeMismatchCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/objc/BUILD.gn

  • This file was added.
static_library("objc") {
output_name = "clangTidyObjCModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//llvm/lib/Support",
]
sources = [
"AvoidNSErrorInitCheck.cpp",
"AvoidSpinlockCheck.cpp",
"ForbiddenSubclassingCheck.cpp",
"ObjCTidyModule.cpp",
"PropertyDeclarationCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/performance/BUILD.gn

  • This file was added.
static_library("performance") {
output_name = "clangTidyPerformanceModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Analysis",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//llvm/lib/Support",
]
sources = [
"FasterStringFindCheck.cpp",
"ForRangeCopyCheck.cpp",
"ImplicitConversionInLoopCheck.cpp",
"InefficientAlgorithmCheck.cpp",
"InefficientStringConcatenationCheck.cpp",
"InefficientVectorOperationCheck.cpp",
"MoveConstArgCheck.cpp",
"MoveConstructorInitCheck.cpp",
"NoexceptMoveConstructorCheck.cpp",
"PerformanceTidyModule.cpp",
"TypePromotionInMathFnCheck.cpp",
"UnnecessaryCopyInitialization.cpp",
"UnnecessaryValueParamCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/plugin/BUILD.gn

  • This file was added.
static_library("plugin") {
output_name = "clangTidyPlugin"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/abseil",
"//clang-tools-extra/clang-tidy/android",
"//clang-tools-extra/clang-tidy/boost",
"//clang-tools-extra/clang-tidy/bugprone",
"//clang-tools-extra/clang-tidy/cert",
"//clang-tools-extra/clang-tidy/cppcoreguidelines",
"//clang-tools-extra/clang-tidy/fuchsia",
"//clang-tools-extra/clang-tidy/google",
"//clang-tools-extra/clang-tidy/hicpp",
"//clang-tools-extra/clang-tidy/llvm",
"//clang-tools-extra/clang-tidy/misc",
"//clang-tools-extra/clang-tidy/modernize",
"//clang-tools-extra/clang-tidy/objc",
"//clang-tools-extra/clang-tidy/performance",
"//clang-tools-extra/clang-tidy/portability",
"//clang-tools-extra/clang-tidy/readability",
"//clang-tools-extra/clang-tidy/zircon",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Frontend",
"//clang/lib/Sema",
"//clang/lib/Tooling",
]
if (clang_enable_static_analyzer) {
deps += [ "//clang-tools-extra/clang-tidy/mpi" ]
}
sources = [
"ClangTidyPlugin.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/portability/BUILD.gn

  • This file was added.
static_library("portability") {
output_name = "clangTidyPortabilityModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//clang/lib/Tooling",
"//llvm/lib/Support",
]
sources = [
"PortabilityTidyModule.cpp",
"SIMDIntrinsicsCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/readability/BUILD.gn

  • This file was added.
static_library("readability") {
output_name = "clangTidyReadabilityModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//clang/lib/Tooling",
"//llvm/lib/Support",
]
sources = [
"AvoidConstParamsInDecls.cpp",
"BracesAroundStatementsCheck.cpp",
"ConstReturnTypeCheck.cpp",
"ContainerSizeEmptyCheck.cpp",
"DeleteNullPointerCheck.cpp",
"DeletedDefaultCheck.cpp",
"ElseAfterReturnCheck.cpp",
"FunctionSizeCheck.cpp",
"IdentifierNamingCheck.cpp",
"ImplicitBoolConversionCheck.cpp",
"InconsistentDeclarationParameterNameCheck.cpp",
"IsolateDeclarationCheck.cpp",
"MagicNumbersCheck.cpp",
"MisleadingIndentationCheck.cpp",
"MisplacedArrayIndexCheck.cpp",
"NamedParameterCheck.cpp",
"NamespaceCommentCheck.cpp",
"NonConstParameterCheck.cpp",
"ReadabilityTidyModule.cpp",
"RedundantControlFlowCheck.cpp",
"RedundantDeclarationCheck.cpp",
"RedundantFunctionPtrDereferenceCheck.cpp",
"RedundantMemberInitCheck.cpp",
"RedundantPreprocessorCheck.cpp",
"RedundantSmartptrGetCheck.cpp",
"RedundantStringCStrCheck.cpp",
"RedundantStringInitCheck.cpp",
"SimplifyBooleanExprCheck.cpp",
"SimplifySubscriptExprCheck.cpp",
"StaticAccessedThroughInstanceCheck.cpp",
"StaticDefinitionInAnonymousNamespaceCheck.cpp",
"StringCompareCheck.cpp",
"UniqueptrDeleteReleaseCheck.cpp",
"UppercaseLiteralSuffixCheck.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/tool/BUILD.gn

  • This file was added.
import("//clang/lib/StaticAnalyzer/Frontend/enable.gni")
executable("clang-tidy") {
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/abseil",
"//clang-tools-extra/clang-tidy/android",
"//clang-tools-extra/clang-tidy/boost",
"//clang-tools-extra/clang-tidy/bugprone",
"//clang-tools-extra/clang-tidy/cert",
"//clang-tools-extra/clang-tidy/cppcoreguidelines",
"//clang-tools-extra/clang-tidy/fuchsia",
"//clang-tools-extra/clang-tidy/google",
"//clang-tools-extra/clang-tidy/hicpp",
"//clang-tools-extra/clang-tidy/llvm",
"//clang-tools-extra/clang-tidy/misc",
"//clang-tools-extra/clang-tidy/modernize",
"//clang-tools-extra/clang-tidy/objc",
"//clang-tools-extra/clang-tidy/performance",
"//clang-tools-extra/clang-tidy/portability",
"//clang-tools-extra/clang-tidy/readability",
"//clang-tools-extra/clang-tidy/zircon",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Tooling",
"//clang/lib/Tooling/Core",
"//llvm/lib/Support",
"//llvm/lib/Target:AllTargetsAsmParsers",
"//llvm/lib/Target:AllTargetsDescs",
"//llvm/lib/Target:AllTargetsInfos",
]
if (clang_enable_static_analyzer) {
deps += [ "//clang-tools-extra/clang-tidy/mpi" ]
}
sources = [
"ClangTidyMain.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/utils/BUILD.gn

  • This file was added.
static_library("utils") {
output_name = "clangTidyUtils"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//llvm/lib/Support",
]
sources = [
"ASTUtils.cpp",
"DeclRefExprUtils.cpp",
"ExprSequence.cpp",
"FixItHintUtils.cpp",
"HeaderFileExtensionsUtils.cpp",
"HeaderGuard.cpp",
"IncludeInserter.cpp",
"IncludeSorter.cpp",
"LexerUtils.cpp",
"NamespaceAliaser.cpp",
"OptionsUtils.cpp",
"TypeTraits.cpp",
"UsingInserter.cpp",
]
}

llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/zircon/BUILD.gn

  • This file was added.
static_library("zircon") {
output_name = "clangTidyZirconModule"
deps = [
"//clang-tools-extra/clang-tidy",
"//clang-tools-extra/clang-tidy/utils",
"//clang/lib/AST",
"//clang/lib/ASTMatchers",
"//clang/lib/Basic",
"//clang/lib/Lex",
"//llvm/lib/Support",
]
sources = [
"TemporaryObjectsCheck.cpp",
"ZirconTidyModule.cpp",
]
}

llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn

static_library("Basic") { static_library("Basic") {
output_name = "clangBasic" output_name = "clangBasic"
configs += [ "//llvm/utils/gn/build:clang_code" ] public_configs = [ "//llvm/utils/gn/build:clang_code" ]
thakisUnsubmitted
Done
ReplyInline Actions

Instead of this, I think it'd be better to say configs += [ "//llvm/utils/gn/build:clang_code" ] in all the clang-tools-extra targets (like all the clang targets do)

thakis: Instead of this, I think it'd be better to say `configs += [ "//llvm/utils/gn/build:clang_code"…
mbonadeiAuthorUnsubmitted
Done
ReplyInline Actions

I see that we are not declaring headers to gn. Is this something we'll want to have in the future? I think this is related to how we look at configs vs public_configs as well.

mbonadei: I see that we are not declaring headers to gn. Is this something we'll want to have in the…
thakisUnsubmitted
Not Done
ReplyInline Actions

Maybe; it's the gn check item in llvm/utils/gn/TODO.txt.

thakis: Maybe; it's the `gn check` item in llvm/utils/gn/TODO.txt.
public_deps = [ public_deps = [
# public_dep because public header Version.h includes generated Version.inc. # public_dep because public header Version.h includes generated Version.inc.
"//clang/include/clang/Basic:AttrList", "//clang/include/clang/Basic:AttrList",
"//clang/include/clang/Basic:AttrSubMatchRulesList", "//clang/include/clang/Basic:AttrSubMatchRulesList",
"//clang/include/clang/Basic:DiagnosticGroups", "//clang/include/clang/Basic:DiagnosticGroups",
"//clang/include/clang/Basic:diags_tablegen", "//clang/include/clang/Basic:diags_tablegen",
"//clang/include/clang/Basic:version", "//clang/include/clang/Basic:version",
] ]
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines

llvm/utils/gn/secondary/llvm/utils/TableGen/tablegen.gni

# This file defines a template for running llvm-tblgen. # This file defines a template for running llvm-tblgen.
# #
# Parameters: # Parameters:
# #
# args (required) # args (required)
# [list of strings] Flags to pass to llvm-tblgen. # [list of strings] Flags to pass to llvm-tblgen.
# #
# output_name (optional) # output_name (optional)
# Basename of the generated output file. # Basename of the generated output file.
# Defaults to target name with ".inc" appended. # Defaults to target name with ".inc" appended.
# #
# td_file (roptional) # td_file (optional)
# The .td file to pass to llvm-tblgen. # The .td file to pass to llvm-tblgen.
# Defaults to target name with ".td" appended. # Defaults to target name with ".td" appended.
# #
# visibility (optional) # visibility (optional)
# GN's regular visibility attribute, see `gn help visibility`. # GN's regular visibility attribute, see `gn help visibility`.
# #
# Example use: # Example use:
# #
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines