Page MenuHomePhabricator

mbonadei (Mirko Bonadei)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2019, 7:28 AM (16 w, 3 d)

Recent Activity

Apr 3 2019

mbonadei accepted D60222: gn build: Add build file for dexp.

LGTM.

Apr 3 2019, 11:51 AM · Restricted Project
mbonadei accepted D60130: gn build: Add build files for clangd xpc framework code.

Really nice work and thanks for the thread on gn-dev about create_bundle!

Apr 3 2019, 4:28 AM · Restricted Project, Restricted Project

Apr 2 2019

mbonadei accepted D60124: gn build: Add build files for non-framework xpc clangd bits.

LGTM, just a couple of comments.

Apr 2 2019, 7:17 AM · Restricted Project

Mar 31 2019

mbonadei accepted D60038: gn build: Add build files for most clang-tools-extra unit tests.

LGTM, just a small style comment.

Mar 31 2019, 5:46 AM · Restricted Project

Mar 28 2019

mbonadei accepted D59955: gn build: Add check-clang-tools to run clang-tools-extra lit tests.

Really nice work!

Mar 28 2019, 3:05 PM · Restricted Project, Restricted Project
mbonadei accepted D59899: gn build: Add some build files for clangd.

Sorry for the delay, LGTM % 2 small comments.

Mar 28 2019, 8:28 AM · Restricted Project

Mar 26 2019

mbonadei accepted D59838: gn build: Add build files for clang-include-fixer and find-all-symbols.

LGTM.

Mar 26 2019, 2:37 PM · Restricted Project

Mar 22 2019

mbonadei accepted D59701: gn build: Add build files for modularize and pp-trace.

LGTM.

Mar 22 2019, 2:31 PM · Restricted Project

Mar 20 2019

mbonadei accepted D59554: gn build: Add build files for some clang-tools-extra.

LGTM!

Mar 20 2019, 8:22 AM · Restricted Project, Restricted Project

Mar 19 2019

mbonadei added inline comments to D59554: gn build: Add build files for some clang-tools-extra.
Mar 19 2019, 10:38 PM · Restricted Project, Restricted Project

Mar 14 2019

mbonadei accepted D59379: gn build: Add build files for clang-doc.

Nice!

Mar 14 2019, 1:25 PM · Restricted Project

Feb 23 2019

mbonadei abandoned D58542: gn build: Merge r354635.

No worries. Thanks for fixing! :)

Feb 23 2019, 10:47 AM · Restricted Project

Feb 22 2019

mbonadei created D58542: gn build: Merge r354635.
Feb 22 2019, 3:13 AM · Restricted Project

Feb 10 2019

mbonadei abandoned D57994: Partially revert "gn build: Merge r353471, r353373.".

No worries. :)

Feb 10 2019, 11:43 PM · Restricted Project

Feb 9 2019

mbonadei added inline comments to D57998: gn build: Fix clang-tidy dep on ClangSACheckers..
Feb 9 2019, 5:49 AM · Restricted Project
mbonadei created D57998: gn build: Fix clang-tidy dep on ClangSACheckers..
Feb 9 2019, 5:46 AM · Restricted Project
mbonadei created D57994: Partially revert "gn build: Merge r353471, r353373.".
Feb 9 2019, 1:55 AM · Restricted Project

Feb 5 2019

mbonadei created D57777: [gn] Fix clang-tidy build.
Feb 5 2019, 12:01 PM · Restricted Project
mbonadei added a comment to D57329: [gn] Checking in BUILD.gn files for clang-tidy and clang-apply-replacements.

I don't have commit access. Can you take care of landing this one?

Feb 5 2019, 7:11 AM · Restricted Project
mbonadei added inline comments to D57329: [gn] Checking in BUILD.gn files for clang-tidy and clang-apply-replacements.
Feb 5 2019, 7:11 AM · Restricted Project
mbonadei added inline comments to D57329: [gn] Checking in BUILD.gn files for clang-tidy and clang-apply-replacements.
Feb 5 2019, 6:25 AM · Restricted Project
mbonadei updated the diff for D57329: [gn] Checking in BUILD.gn files for clang-tidy and clang-apply-replacements.
Feb 5 2019, 6:25 AM · Restricted Project

Feb 4 2019

mbonadei added a comment to D57329: [gn] Checking in BUILD.gn files for clang-tidy and clang-apply-replacements.

(Please give me a few more days too. Sorry it's taking so long, have been firefighting all week :-/)

Feb 4 2019, 5:18 AM · Restricted Project

Jan 28 2019

mbonadei created D57329: [gn] Checking in BUILD.gn files for clang-tidy and clang-apply-replacements.
Jan 28 2019, 7:48 AM · Restricted Project