[LLD] [MinGW] Ignore the --plugin and --plugin-opt options

[mstorsjo]

Summary

GCC can use LLD with -fuse-ld=lld for MinGW these days, but by default these options are passed to the linker (unless -fno-lto is passed to the GCC driver).

[mstorsjo]

Added --plugin-opt as well.

[ruiu]

MinGW/Options.td

71–74

I prefer not to name options if they are ignored. I mean you can define these options as shown below

def: S<"plugin">;
def: J<"plugin=">;
def: S<"plugin-opt">;
def: J<"plugin-opt=">;

and that clearly conveys the intention that they are ignored, because you don't have a way to refer them.

[mstorsjo]

Applied @ruiu's comments.

Or should I move them to another section entirely? (The rest of the surrounding ones do have names, but are ignored.)

[ruiu]

LGTM

Yeah, I think I'd move them to the end of the file.

[mstorsjo]

@hans - Can we cherrypick this one to the 8.0 release branch? A user requested it, as it would allow using LLD with GCC for MinGW.

MinGW/Options.td

 def end_group: F<"end-group">;
 def full_shutdown: Flag<["--"], "full-shutdown">;
 def high_entropy_va: F<"high-entropy-va">, HelpText<"Enable 64-bit ASLR">;
 def major_image_version: S<"major-image-version">;
 def minor_image_version: S<"minor-image-version">;
 def no_seh: F<"no-seh">;
 def nxcompat: F<"nxcompat">, HelpText<"Enable data execution prevention">;
 def pic_executable: F<"pic-executable">;
 def sysroot: J<"sysroot">, HelpText<"Sysroot">;
 def start_group: F<"start-group">;
 def tsaware: F<"tsaware">, HelpText<"Create Terminal Server aware executable">;
 def v: Flag<["-"], "v">, HelpText<"Display the version number">;
 def version: F<"version">, HelpText<"Display the version number and exit">;
 
 // Alias
 def alias_entry_e: JoinedOrSeparate<["-"], "e">, Alias<entry>;
 def alias_strip_s: Flag<["-"], "s">, Alias<strip_all>;
 def alias_strip_S: Flag<["-"], "S">, Alias<strip_debug>;
+
+// Ignored options
+def: S<"plugin">;
+def: J<"plugin=">;
+def: S<"plugin-opt">;
+def: J<"plugin-opt=">;