This is an archive of the discontinued LLVM Phabricator instance.

[COFF] Add new relocation types.
ClosedPublic

Authored by mstorsjo on Jan 26 2019, 12:44 PM.

Diff Detail

Event Timeline

mstorsjo created this revision.Jan 26 2019, 12:44 PM
mstorsjo added a reviewer: TomTan.
pcc accepted this revision.Jan 26 2019, 1:36 PM

LGTM

include/llvm/BinaryFormat/COFF.h
374

You might want to add IMAGE_REL_ARM_REL32 here, which is also new to the 11/04/2018 revision of the spec.

This revision is now accepted and ready to land.Jan 26 2019, 1:36 PM
mstorsjo marked an inline comment as done.Jan 26 2019, 1:42 PM
mstorsjo added inline comments.
include/llvm/BinaryFormat/COFF.h
374

Oh, I didn't notice that one as it was in the middle of the range.

mstorsjo updated this revision to Diff 183730.Jan 26 2019, 1:58 PM

Added IMAGE_REL_ARM_REL32.

pcc accepted this revision.Jan 26 2019, 3:17 PM

LGTM

This revision was automatically updated to reflect the committed changes.