AMDGPU/GlobalISel: Legalize constant for pointer types

[arsenm]

ping

[tstellar]

test/CodeGen/AMDGPU/GlobalISel/legalize-constant.mir

102

Does this need to be i64 here? Same for the other 64-bit address spaces.

[arsenm]

test/CodeGen/AMDGPU/GlobalISel/legalize-constant.mir

102

I'm not sure what the policy is for the integer size on G_CONSTANT. The verifier doesn't complain. buildConstant does a sextOrTrunc to convert to the element type. I'll fix this before committing

[tstellar]

OK, LGTM.

[arsenm]

r352975

lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp

.legalIf([=](const LegalityQuery &Query) {
         return Query.Types[0].getSizeInBits() <= 512;
     })
     .clampScalar(0, S1, S512);
 
 
   // FIXME: i1 operands to intrinsics should always be legal, but other i1
   // values may not be legal.  We need to figure out how to distinguish
   // between these two scenarios.
-  // FIXME: Pointer types
   getActionDefinitionsBuilder(G_CONSTANT)
-    .legalFor({S1, S32, S64})
+    .legalFor({S1, S32, S64, GlobalPtr,
+               LocalPtr, ConstantPtr, PrivatePtr, FlatPtr, })
     .clampScalar(0, S32, S64)
-    .widenScalarToNextPow2(0);
+    .widenScalarToNextPow2(0)
+    .legalIf(isPointer(0));
 
   setAction({G_FRAME_INDEX, PrivatePtr}, Legal);
 
   getActionDefinitionsBuilder({G_FADD, G_FMUL, G_FNEG, G_FABS, G_FMA})
       .legalFor({S32, S64})
       .scalarize(0)
       .clampScalar(0, S32, S64);
 

test/CodeGen/AMDGPU/GlobalISel/legalize-constant.mir

bb.0:
     ; CHECK-LABEL: name: test_constant_s128
     ; CHECK: [[C:%[0-9]+]]:_(s64) = G_CONSTANT i64 5
     ; CHECK: [[C1:%[0-9]+]]:_(s64) = G_CONSTANT i64 0
     ; CHECK: [[MV:%[0-9]+]]:_(s128) = G_MERGE_VALUES [[C]](s64), [[C1]](s64)
     ; CHECK: $vgpr0_vgpr1_vgpr2_vgpr3 = COPY [[MV]](s128)
     %0:_(s128) = G_CONSTANT i128 5
     $vgpr0_vgpr1_vgpr2_vgpr3 = COPY %0
 ...
+
+---
+name: test_constant_p0
+body: |
+  bb.0:
+
+    ; CHECK-LABEL: name: test_constant_p0
+    ; CHECK: [[C:%[0-9]+]]:_(p0) = G_CONSTANT i32 0
+    ; CHECK: $vgpr0_vgpr1 = COPY [[C]](p0)
+    %0:_(p0) = G_CONSTANT i32 0
+    $vgpr0_vgpr1 = COPY %0
+...
+
+---
+name: test_constant_p1
+body: |
+  bb.0:
+
+    ; CHECK-LABEL: name: test_constant_p1
+    ; CHECK: [[C:%[0-9]+]]:_(p1) = G_CONSTANT i32 0
+    ; CHECK: $vgpr0_vgpr1 = COPY [[C]](p1)
+    %0:_(p1) = G_CONSTANT i32 0
+    $vgpr0_vgpr1 = COPY %0
+...
+
+---
+name: test_constant_p2
+body: |
+  bb.0:
+
+    ; CHECK-LABEL: name: test_constant_p2
+    ; CHECK: [[C:%[0-9]+]]:_(p2) = G_CONSTANT i32 0
+    ; CHECK: $vgpr0 = COPY [[C]](p2)
+    %0:_(p2) = G_CONSTANT i32 0
+    $vgpr0 = COPY %0
+...
+
+---
+name: test_constant_p3
+body: |
+  bb.0:
+
+    ; CHECK-LABEL: name: test_constant_p3
+    ; CHECK: [[C:%[0-9]+]]:_(p2) = G_CONSTANT i32 0
+    ; CHECK: $vgpr0 = COPY [[C]](p2)
+    %0:_(p2) = G_CONSTANT i32 0
+    $vgpr0 = COPY %0
+...
+
+---
+name: test_constant_p4
+body: |
+  bb.0:
+
+    ; CHECK-LABEL: name: test_constant_p4
+    ; CHECK: [[C:%[0-9]+]]:_(p4) = G_CONSTANT i32 0
+    ; CHECK: $vgpr0_vgpr1 = COPY [[C]](p4)
+    %0:_(p4) = G_CONSTANT i32 0
+    $vgpr0_vgpr1 = COPY %0
+...
+
+---
+name: test_constant_p5
+body: |
+  bb.0:
+
+    ; CHECK-LABEL: name: test_constant_p5
+    ; CHECK: [[C:%[0-9]+]]:_(p5) = G_CONSTANT i32 0
+    ; CHECK: $vgpr0 = COPY [[C]](p5)
+    %0:_(p5) = G_CONSTANT i32 0
+    $vgpr0 = COPY %0
+...
+
+---
+name: test_constant_p999
+body: |
+  bb.0:
+
+    ; CHECK-LABEL: name: test_constant_p999
+    ; CHECK: [[C:%[0-9]+]]:_(p999) = G_CONSTANT i32 0
+    ; CHECK: $vgpr0_vgpr1 = COPY [[C]](p999)
+    %0:_(p999) = G_CONSTANT i32 0
+    $vgpr0_vgpr1 = COPY %0
+...