This is an archive of the discontinued LLVM Phabricator instance.

Differential D57042

[clangd] NFC: reduce log noise from Diagnostics.
ClosedPublic

Authored by ioeric on Jan 22 2019, 1:56 AM.

Details

Reviewers
sammccall
Commits
rG464bbe58122d: [clangd] NFC: reduce log noise from Diagnostics.
rCTE351813: [clangd] NFC: reduce log noise from Diagnostics.
rL351813: [clangd] NFC: reduce log noise from Diagnostics.

Diff Detail

Repository
rL LLVM

Event Timeline

ioeric created this revision.Jan 22 2019, 1:56 AM
Herald added subscribers: cfe-commits, kadircet, arphaman and 3 others. · View Herald TranscriptJan 22 2019, 1:56 AM
Harbormaster completed remote builds in B27147: Diff 182863.Jan 22 2019, 1:56 AM
sammccall accepted this revision.Jan 22 2019, 4:32 AM
This revision is now accepted and ready to land.Jan 22 2019, 4:32 AM
Closed by commit rL351813: [clangd] NFC: reduce log noise from Diagnostics. (authored by ioeric). · Explain WhyJan 22 2019, 4:55 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 22 2019, 4:55 AM

Revision Contents

PathSize
clang-tools-extra/
trunk/
clangd/
4 lines

Diff 182891

clang-tools-extra/trunk/clangd/Diagnostics.cpp

Show First 20 Lines • Show All 397 Lines • ▼ Show 20 Lines
} }
void StoreDiags::flushLastDiag() { void StoreDiags::flushLastDiag() {
if (!LastDiag) if (!LastDiag)
return; return;
if (mentionsMainFile(*LastDiag)) if (mentionsMainFile(*LastDiag))
Output.push_back(std::move(*LastDiag)); Output.push_back(std::move(*LastDiag));
else else
log("Dropped diagnostic outside main file: {0}: {1}", LastDiag->File, vlog("Dropped diagnostic outside main file: {0}: {1}", LastDiag->File,
LastDiag->Message); LastDiag->Message);
LastDiag.reset(); LastDiag.reset();
} }
} // namespace clangd } // namespace clangd
} // namespace clang } // namespace clang