This is an archive of the discontinued LLVM Phabricator instance.

Differential D56947

[WebAssembly] Fix crash with LTO + relocatable + undefined symbols
ClosedPublic

Authored by sbc100 on Jan 18 2019, 4:44 PM.

Details

Reviewers
kripken
ruiu
pcc
Commits
rG89e4dcb4be63: [WebAssembly] Fix crash with LTO + relocatable + undefined symbols
rLLD352645: [WebAssembly] Fix crash with LTO + relocatable + undefined symbols
rL352645: [WebAssembly] Fix crash with LTO + relocatable + undefined symbols
Summary

Change the way we create the symbol table to be closer to how its down on ELF.
Now the output symbol table matches the internal symtab data structure more closely
and includes local and undefined symbols.

Fixes PR40204

Diff Detail

Event Timeline

sbc100 created this revision.Jan 18 2019, 4:44 PM
Herald added subscribers: llvm-commits, dexonsmith, steven_wu and 6 others. · View Herald TranscriptJan 18 2019, 4:44 PM
sbc100 edited the summary of this revision. (Show Details)Jan 18 2019, 4:44 PM
sbc100 added reviewers: kripken, ruiu.
sbc100 updated this revision to Diff 182643.Jan 18 2019, 4:45 PM

Revert debugging

Harbormaster completed remote builds in B27084: Diff 182642.Jan 18 2019, 4:46 PM
Harbormaster completed remote builds in B27085: Diff 182643.
ruiu added a reviewer: pcc.Jan 22 2019, 2:23 PM
pcc added inline comments.Jan 22 2019, 2:50 PM
wasm/Writer.cpp
905

Maybe this would be better as

for (Symbol *Sym : Symtab->getSymbols()) {
  // handle global symbols
}

for (ObjFile *File : Symtab->ObjectFiles) {
  for (Symbol *Sym : File->getSymbols()) {
    if (!Sym->isLocal())
      continue;
    // handle local/section symbols
  }
}

? I believe that's how we handle .symtab in ELF for example.

sbc100 updated this revision to Diff 184321.Jan 30 2019, 10:07 AM
sbc100 marked 2 inline comments as done.
  • refactor symtab creation
Harbormaster completed remote builds in B27497: Diff 184321.Jan 30 2019, 10:08 AM
sbc100 edited the summary of this revision. (Show Details)Jan 30 2019, 10:09 AM
ruiu accepted this revision.Jan 30 2019, 10:46 AM

LGTM

wasm/Writer.cpp
907

Symbol* -> Symbol *

This revision is now accepted and ready to land.Jan 30 2019, 10:46 AM
Closed by commit rL352645: [WebAssembly] Fix crash with LTO + relocatable + undefined symbols (authored by sbc). · Explain WhyJan 30 2019, 10:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
wasm/
6 lines
86 lines
146 lines
lto/
36 lines
28 lines
wasm/
58 lines

Diff 184321

test/wasm/data-layout.ll

Show First 20 Lines • Show All 79 Lines • ▼ Show 20 Lines
; CHECK-SHARED-NEXT: Maximum: 0x00000002 ; CHECK-SHARED-NEXT: Maximum: 0x00000002
; RUN: wasm-ld --relocatable -o %t_reloc.wasm %t.o %t.hello.o ; RUN: wasm-ld --relocatable -o %t_reloc.wasm %t.o %t.hello.o
; RUN: obj2yaml %t_reloc.wasm | FileCheck %s -check-prefix=RELOC ; RUN: obj2yaml %t_reloc.wasm | FileCheck %s -check-prefix=RELOC
; RELOC: - Type: DATA ; RELOC: - Type: DATA
; RELOC-NEXT: Relocations: ; RELOC-NEXT: Relocations:
; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_I32 ; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_I32
; RELOC-NEXT: Index: 6 ; RELOC-NEXT: Index: 3
; RELOC-NEXT: Offset: 0x00000018 ; RELOC-NEXT: Offset: 0x00000018
; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_I32 ; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_I32
; RELOC-NEXT: Index: 3 ; RELOC-NEXT: Index: 4
; RELOC-NEXT: Offset: 0x0000002E ; RELOC-NEXT: Offset: 0x0000002E
; RELOC-NEXT: Addend: 4 ; RELOC-NEXT: Addend: 4
; RELOC-NEXT: Segments: ; RELOC-NEXT: Segments:
; RELOC-NEXT: - SectionOffset: 6 ; RELOC-NEXT: - SectionOffset: 6
; RELOC-NEXT: MemoryIndex: 0 ; RELOC-NEXT: MemoryIndex: 0
; RELOC-NEXT: Offset: ; RELOC-NEXT: Offset:
; RELOC-NEXT: Opcode: I32_CONST ; RELOC-NEXT: Opcode: I32_CONST
; RELOC-NEXT: Value: 0 ; RELOC-NEXT: Value: 0
▲ Show 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
; RELOC-NEXT: Segment: 1 ; RELOC-NEXT: Segment: 1
; RELOC-NEXT: Size: 4 ; RELOC-NEXT: Size: 4
; RELOC-NEXT: - Index: 2 ; RELOC-NEXT: - Index: 2
; RELOC-NEXT: Kind: DATA ; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: external_ref ; RELOC-NEXT: Name: external_ref
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Segment: 2 ; RELOC-NEXT: Segment: 2
; RELOC-NEXT: Size: 4 ; RELOC-NEXT: Size: 4
; RELOC: - Index: 6 ; RELOC-NEXT: - Index: 3
; RELOC-NEXT: Kind: DATA ; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: hello_str ; RELOC-NEXT: Name: hello_str
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Segment: 5 ; RELOC-NEXT: Segment: 5
; RELOC-NEXT: Size: 7 ; RELOC-NEXT: Size: 7

test/wasm/init-fini.ll

Show First 20 Lines • Show All 157 Lines • ▼ Show 20 Lines
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 6 ; RELOC-NEXT: Function: 6
; RELOC-NEXT: - Index: 5 ; RELOC-NEXT: - Index: 5
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: _start ; RELOC-NEXT: Name: _start
; RELOC-NEXT: Flags: [ VISIBILITY_HIDDEN ] ; RELOC-NEXT: Flags: [ VISIBILITY_HIDDEN ]
; RELOC-NEXT: Function: 7 ; RELOC-NEXT: Function: 7
; RELOC-NEXT: - Index: 6 ; RELOC-NEXT: - Index: 6
; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: __dso_handle
; RELOC-NEXT: Flags: [ BINDING_WEAK, VISIBILITY_HIDDEN, UNDEFINED ]
; RELOC-NEXT: - Index: 7
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: externDtor
; RELOC-NEXT: Flags: [ VISIBILITY_HIDDEN, UNDEFINED ]
; RELOC-NEXT: Function: 0
; RELOC-NEXT: - Index: 8
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: externCtor
; RELOC-NEXT: Flags: [ VISIBILITY_HIDDEN, UNDEFINED ]
; RELOC-NEXT: Function: 1
; RELOC-NEXT: - Index: 9
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: myctor
; RELOC-NEXT: Flags: [ VISIBILITY_HIDDEN ]
; RELOC-NEXT: Function: 14
; RELOC-NEXT: - Index: 10
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: mydtor
; RELOC-NEXT: Flags: [ VISIBILITY_HIDDEN ]
; RELOC-NEXT: Function: 15
; RELOC-NEXT: - Index: 11
; RELOC-NEXT: Kind: GLOBAL
; RELOC-NEXT: Name: __stack_pointer
; RELOC-NEXT: Flags: [ UNDEFINED ]
; RELOC-NEXT: Global: 0
; RELOC-NEXT: - Index: 12
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: .Lcall_dtors.101 ; RELOC-NEXT: Name: .Lcall_dtors.101
; RELOC-NEXT: Flags: [ BINDING_LOCAL ] ; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 8 ; RELOC-NEXT: Function: 8
; RELOC-NEXT: - Index: 7 ; RELOC-NEXT: - Index: 13
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: .Lregister_call_dtors.101 ; RELOC-NEXT: Name: .Lregister_call_dtors.101
; RELOC-NEXT: Flags: [ BINDING_LOCAL ] ; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 9 ; RELOC-NEXT: Function: 9
; RELOC-NEXT: - Index: 8 ; RELOC-NEXT: - Index: 14
; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: __dso_handle
; RELOC-NEXT: Flags: [ BINDING_WEAK, VISIBILITY_HIDDEN, UNDEFINED ]
; RELOC-NEXT: - Index: 9
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: .Lcall_dtors.1001 ; RELOC-NEXT: Name: .Lcall_dtors.1001
; RELOC-NEXT: Flags: [ BINDING_LOCAL ] ; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 10 ; RELOC-NEXT: Function: 10
; RELOC-NEXT: - Index: 10 ; RELOC-NEXT: - Index: 15
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: .Lregister_call_dtors.1001 ; RELOC-NEXT: Name: .Lregister_call_dtors.1001
; RELOC-NEXT: Flags: [ BINDING_LOCAL ] ; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 11 ; RELOC-NEXT: Function: 11
; RELOC-NEXT: - Index: 11 ; RELOC-NEXT: - Index: 16
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: .Lcall_dtors.4000 ; RELOC-NEXT: Name: .Lcall_dtors.4000
; RELOC-NEXT: Flags: [ BINDING_LOCAL ] ; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 12 ; RELOC-NEXT: Function: 12
; RELOC-NEXT: - Index: 12 ; RELOC-NEXT: - Index: 17
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: externDtor
; RELOC-NEXT: Flags: [ VISIBILITY_HIDDEN, UNDEFINED ]
; RELOC-NEXT: Function: 0
; RELOC-NEXT: - Index: 13
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: .Lregister_call_dtors.4000 ; RELOC-NEXT: Name: .Lregister_call_dtors.4000
; RELOC-NEXT: Flags: [ BINDING_LOCAL ] ; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 13 ; RELOC-NEXT: Function: 13
; RELOC-NEXT: - Index: 14
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: externCtor
; RELOC-NEXT: Flags: [ VISIBILITY_HIDDEN, UNDEFINED ]
; RELOC-NEXT: Function: 1
; RELOC-NEXT: - Index: 15
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: myctor
; RELOC-NEXT: Flags: [ VISIBILITY_HIDDEN ]
; RELOC-NEXT: Function: 14
; RELOC-NEXT: - Index: 16
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: mydtor
; RELOC-NEXT: Flags: [ VISIBILITY_HIDDEN ]
; RELOC-NEXT: Function: 15
; RELOC-NEXT: - Index: 17
; RELOC-NEXT: Kind: GLOBAL
; RELOC-NEXT: Name: __stack_pointer
; RELOC-NEXT: Flags: [ UNDEFINED ]
; RELOC-NEXT: Global: 0
; RELOC-NEXT: - Index: 18 ; RELOC-NEXT: - Index: 18
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: .Lcall_dtors.101 ; RELOC-NEXT: Name: .Lcall_dtors.101
; RELOC-NEXT: Flags: [ BINDING_LOCAL ] ; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 16 ; RELOC-NEXT: Function: 16
; RELOC-NEXT: - Index: 19 ; RELOC-NEXT: - Index: 19
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: .Lregister_call_dtors.101 ; RELOC-NEXT: Name: .Lregister_call_dtors.101
Show All 14 Lines
; RELOC-NEXT: Name: .Lcall_dtors.2002 ; RELOC-NEXT: Name: .Lcall_dtors.2002
; RELOC-NEXT: Flags: [ BINDING_LOCAL ] ; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 20 ; RELOC-NEXT: Function: 20
; RELOC-NEXT: - Index: 23 ; RELOC-NEXT: - Index: 23
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: .Lregister_call_dtors.2002 ; RELOC-NEXT: Name: .Lregister_call_dtors.2002
; RELOC-NEXT: Flags: [ BINDING_LOCAL ] ; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 21 ; RELOC-NEXT: Function: 21
; RELOC-NEXT: InitFunctions: ; RELOC-NEXT: InitFunctions:
; RELOC-NEXT: - Priority: 101 ; RELOC-NEXT: - Priority: 101
; RELOC-NEXT: Symbol: 0 ; RELOC-NEXT: Symbol: 0
; RELOC-NEXT: - Priority: 101 ; RELOC-NEXT: - Priority: 101
; RELOC-NEXT: Symbol: 1 ; RELOC-NEXT: Symbol: 1
; RELOC-NEXT: - Priority: 101 ; RELOC-NEXT: - Priority: 101
; RELOC-NEXT: Symbol: 7 ; RELOC-NEXT: Symbol: 13
; RELOC-NEXT: - Priority: 101 ; RELOC-NEXT: - Priority: 101
; RELOC-NEXT: Symbol: 15 ; RELOC-NEXT: Symbol: 9
; RELOC-NEXT: - Priority: 101 ; RELOC-NEXT: - Priority: 101
; RELOC-NEXT: Symbol: 19 ; RELOC-NEXT: Symbol: 19
; RELOC-NEXT: - Priority: 202 ; RELOC-NEXT: - Priority: 202
; RELOC-NEXT: Symbol: 15 ; RELOC-NEXT: Symbol: 9
; RELOC-NEXT: - Priority: 202 ; RELOC-NEXT: - Priority: 202
; RELOC-NEXT: Symbol: 21 ; RELOC-NEXT: Symbol: 21
; RELOC-NEXT: - Priority: 1001 ; RELOC-NEXT: - Priority: 1001
; RELOC-NEXT: Symbol: 0 ; RELOC-NEXT: Symbol: 0
; RELOC-NEXT: - Priority: 1001 ; RELOC-NEXT: - Priority: 1001
; RELOC-NEXT: Symbol: 10
; RELOC-NEXT: - Priority: 2002
; RELOC-NEXT: Symbol: 15 ; RELOC-NEXT: Symbol: 15
; RELOC-NEXT: - Priority: 2002 ; RELOC-NEXT: - Priority: 2002
; RELOC-NEXT: Symbol: 9
; RELOC-NEXT: - Priority: 2002
; RELOC-NEXT: Symbol: 23 ; RELOC-NEXT: Symbol: 23
; RELOC-NEXT: - Priority: 4000 ; RELOC-NEXT: - Priority: 4000
; RELOC-NEXT: Symbol: 14 ; RELOC-NEXT: Symbol: 8
; RELOC-NEXT: - Priority: 4000 ; RELOC-NEXT: - Priority: 4000
; RELOC-NEXT: Symbol: 13 ; RELOC-NEXT: Symbol: 17
; RELOC-NEXT: - Type: CUSTOM ; RELOC-NEXT: - Type: CUSTOM
; RELOC-NEXT: Name: name ; RELOC-NEXT: Name: name
; RELOC-NEXT: FunctionNames: ; RELOC-NEXT: FunctionNames:
; RELOC-NEXT: - Index: 0 ; RELOC-NEXT: - Index: 0
; RELOC-NEXT: Name: externDtor ; RELOC-NEXT: Name: externDtor
; RELOC-NEXT: - Index: 1 ; RELOC-NEXT: - Index: 1
; RELOC-NEXT: Name: externCtor ; RELOC-NEXT: Name: externCtor
; RELOC-NEXT: - Index: 2 ; RELOC-NEXT: - Index: 2
; RELOC-NEXT: Name: func1 ; RELOC-NEXT: Name: func1
; RELOC-NEXT: - Index: 3 ; RELOC-NEXT: - Index: 3
; RELOC-NEXT: Name: func2 ; RELOC-NEXT: Name: func2
Show All 37 Lines

test/wasm/locals-duplicate.test

Show First 20 Lines • Show All 264 Lines • ▼ Show 20 Lines
; RELOC-NEXT: Segments: ; RELOC-NEXT: Segments:
; RELOC-NEXT: - Offset: ; RELOC-NEXT: - Offset:
; RELOC-NEXT: Opcode: I32_CONST ; RELOC-NEXT: Opcode: I32_CONST
; RELOC-NEXT: Value: 1 ; RELOC-NEXT: Value: 1
; RELOC-NEXT: Functions: [ 0, 1, 2, 9, 10, 11 ] ; RELOC-NEXT: Functions: [ 0, 1, 2, 9, 10, 11 ]
; RELOC-NEXT: - Type: CODE ; RELOC-NEXT: - Type: CODE
; RELOC-NEXT: Relocations: ; RELOC-NEXT: Relocations:
; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_SLEB
; RELOC-NEXT: Index: 4 ; RELOC-NEXT: Index: 18
; RELOC-NEXT: Offset: 0x00000013 ; RELOC-NEXT: Offset: 0x00000013
; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_SLEB
; RELOC-NEXT: Index: 6 ; RELOC-NEXT: Index: 3
; RELOC-NEXT: Offset: 0x0000001C ; RELOC-NEXT: Offset: 0x0000001C
; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_SLEB
; RELOC-NEXT: Index: 8 ; RELOC-NEXT: Index: 19
; RELOC-NEXT: Offset: 0x00000025 ; RELOC-NEXT: Offset: 0x00000025
; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB
; RELOC-NEXT: Index: 0 ; RELOC-NEXT: Index: 16
; RELOC-NEXT: Offset: 0x0000002E ; RELOC-NEXT: Offset: 0x0000002E
; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB
; RELOC-NEXT: Index: 1 ; RELOC-NEXT: Index: 0
; RELOC-NEXT: Offset: 0x00000037 ; RELOC-NEXT: Offset: 0x00000037
; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB
; RELOC-NEXT: Index: 2 ; RELOC-NEXT: Index: 17
; RELOC-NEXT: Offset: 0x00000040 ; RELOC-NEXT: Offset: 0x00000040
; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_SLEB
; RELOC-NEXT: Index: 16 ; RELOC-NEXT: Index: 10
; RELOC-NEXT: Offset: 0x00000058 ; RELOC-NEXT: Offset: 0x00000058
; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_SLEB
; RELOC-NEXT: Index: 18 ; RELOC-NEXT: Index: 22
; RELOC-NEXT: Offset: 0x00000061 ; RELOC-NEXT: Offset: 0x00000061
; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_MEMORY_ADDR_SLEB
; RELOC-NEXT: Index: 20 ; RELOC-NEXT: Index: 23
; RELOC-NEXT: Offset: 0x0000006A ; RELOC-NEXT: Offset: 0x0000006A
; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB
; RELOC-NEXT: Index: 12 ; RELOC-NEXT: Index: 8
; RELOC-NEXT: Offset: 0x00000073 ; RELOC-NEXT: Offset: 0x00000073
; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB
; RELOC-NEXT: Index: 13 ; RELOC-NEXT: Index: 20
; RELOC-NEXT: Offset: 0x0000007C ; RELOC-NEXT: Offset: 0x0000007C
; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB
; RELOC-NEXT: Index: 14 ; RELOC-NEXT: Index: 21
; RELOC-NEXT: Offset: 0x00000085 ; RELOC-NEXT: Offset: 0x00000085
; RELOC-NEXT: Functions: ; RELOC-NEXT: Functions:
; RELOC-NEXT: - Index: 0 ; RELOC-NEXT: - Index: 0
; RELOC-NEXT: Locals: ; RELOC-NEXT: Locals:
; RELOC-NEXT: Body: 41020B ; RELOC-NEXT: Body: 41020B
; RELOC-NEXT: - Index: 1 ; RELOC-NEXT: - Index: 1
; RELOC-NEXT: Locals: ; RELOC-NEXT: Locals:
; RELOC-NEXT: Body: 41020B ; RELOC-NEXT: Body: 41020B
▲ Show 20 Lines • Show All 66 Lines • ▼ Show 20 Lines
; RELOC-NEXT: Value: 16 ; RELOC-NEXT: Value: 16
; RELOC-NEXT: Content: '0000000000000000' ; RELOC-NEXT: Content: '0000000000000000'
; RELOC-NEXT: - Type: CUSTOM ; RELOC-NEXT: - Type: CUSTOM
; RELOC-NEXT: Name: linking ; RELOC-NEXT: Name: linking
; RELOC-NEXT: Version: 2 ; RELOC-NEXT: Version: 2
; RELOC-NEXT: SymbolTable: ; RELOC-NEXT: SymbolTable:
; RELOC-NEXT: - Index: 0 ; RELOC-NEXT: - Index: 0
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: colliding_func1
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 0
; RELOC-NEXT: - Index: 1
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: colliding_func2 ; RELOC-NEXT: Name: colliding_func2
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 1 ; RELOC-NEXT: Function: 1
; RELOC-NEXT: - Index: 2 ; RELOC-NEXT: - Index: 1
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: colliding_func3
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 2
; RELOC-NEXT: - Index: 3
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: get_global1A ; RELOC-NEXT: Name: get_global1A
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 3 ; RELOC-NEXT: Function: 3
; RELOC-NEXT: - Index: 4 ; RELOC-NEXT: - Index: 2
; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: colliding_global1
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Segment: 0
; RELOC-NEXT: Size: 4
; RELOC-NEXT: - Index: 5
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: get_global2A ; RELOC-NEXT: Name: get_global2A
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 4 ; RELOC-NEXT: Function: 4
; RELOC-NEXT: - Index: 6 ; RELOC-NEXT: - Index: 3
; RELOC-NEXT: Kind: DATA ; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: colliding_global2 ; RELOC-NEXT: Name: colliding_global2
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Segment: 1 ; RELOC-NEXT: Segment: 1
; RELOC-NEXT: Size: 4 ; RELOC-NEXT: Size: 4
; RELOC-NEXT: - Index: 7 ; RELOC-NEXT: - Index: 4
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: get_global3A ; RELOC-NEXT: Name: get_global3A
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 5 ; RELOC-NEXT: Function: 5
; RELOC-NEXT: - Index: 8 ; RELOC-NEXT: - Index: 5
; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: colliding_global3
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Segment: 2
; RELOC-NEXT: Size: 4
; RELOC-NEXT: - Index: 9
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: get_func1A ; RELOC-NEXT: Name: get_func1A
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 6 ; RELOC-NEXT: Function: 6
; RELOC-NEXT: - Index: 10 ; RELOC-NEXT: - Index: 6
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: get_func2A ; RELOC-NEXT: Name: get_func2A
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 7 ; RELOC-NEXT: Function: 7
; RELOC-NEXT: - Index: 11 ; RELOC-NEXT: - Index: 7
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: get_func3A ; RELOC-NEXT: Name: get_func3A
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 8 ; RELOC-NEXT: Function: 8
; RELOC-NEXT: - Index: 12 ; RELOC-NEXT: - Index: 8
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: colliding_func1 ; RELOC-NEXT: Name: colliding_func1
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 9 ; RELOC-NEXT: Function: 9
; RELOC-NEXT: - Index: 13 ; RELOC-NEXT: - Index: 9
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: colliding_func2
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 10
; RELOC-NEXT: - Index: 14
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: colliding_func3
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 11
; RELOC-NEXT: - Index: 15
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: get_global1B ; RELOC-NEXT: Name: get_global1B
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 12 ; RELOC-NEXT: Function: 12
; RELOC-NEXT: - Index: 16 ; RELOC-NEXT: - Index: 10
; RELOC-NEXT: Kind: DATA ; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: colliding_global1 ; RELOC-NEXT: Name: colliding_global1
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Segment: 0 ; RELOC-NEXT: Segment: 0
; RELOC-NEXT: Offset: 4 ; RELOC-NEXT: Offset: 4
; RELOC-NEXT: Size: 4 ; RELOC-NEXT: Size: 4
; RELOC-NEXT: - Index: 17 ; RELOC-NEXT: - Index: 11
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: get_global2B ; RELOC-NEXT: Name: get_global2B
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 13 ; RELOC-NEXT: Function: 13
; RELOC-NEXT: - Index: 18 ; RELOC-NEXT: - Index: 12
; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: colliding_global2
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Segment: 1
; RELOC-NEXT: Offset: 4
; RELOC-NEXT: Size: 4
; RELOC-NEXT: - Index: 19
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: get_global3B ; RELOC-NEXT: Name: get_global3B
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 14 ; RELOC-NEXT: Function: 14
; RELOC-NEXT: - Index: 20 ; RELOC-NEXT: - Index: 13
; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: colliding_global3
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Segment: 2
; RELOC-NEXT: Offset: 4
; RELOC-NEXT: Size: 4
; RELOC-NEXT: - Index: 21
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: get_func1B ; RELOC-NEXT: Name: get_func1B
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 15 ; RELOC-NEXT: Function: 15
; RELOC-NEXT: - Index: 22 ; RELOC-NEXT: - Index: 14
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: get_func2B ; RELOC-NEXT: Name: get_func2B
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 16 ; RELOC-NEXT: Function: 16
; RELOC-NEXT: - Index: 23 ; RELOC-NEXT: - Index: 15
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: get_func3B ; RELOC-NEXT: Name: get_func3B
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 17 ; RELOC-NEXT: Function: 17
; RELOC-NEXT: - Index: 16
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: colliding_func1
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 0
; RELOC-NEXT: - Index: 17
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: colliding_func3
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 2
; RELOC-NEXT: - Index: 18
; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: colliding_global1
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Segment: 0
; RELOC-NEXT: Size: 4
; RELOC-NEXT: - Index: 19
; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: colliding_global3
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Segment: 2
; RELOC-NEXT: Size: 4
; RELOC-NEXT: - Index: 20
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: colliding_func2
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 10
; RELOC-NEXT: - Index: 21
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: colliding_func3
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Function: 11
; RELOC-NEXT: - Index: 22
; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: colliding_global2
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Segment: 1
; RELOC-NEXT: Offset: 4
; RELOC-NEXT: Size: 4
; RELOC-NEXT: - Index: 23
; RELOC-NEXT: Kind: DATA
; RELOC-NEXT: Name: colliding_global3
; RELOC-NEXT: Flags: [ BINDING_LOCAL ]
; RELOC-NEXT: Segment: 2
; RELOC-NEXT: Offset: 4
; RELOC-NEXT: Size: 4
; RELOC-NEXT: SegmentInfo: ; RELOC-NEXT: SegmentInfo:
; RELOC-NEXT: - Index: 0 ; RELOC-NEXT: - Index: 0
; RELOC-NEXT: Name: .bss.colliding_global1 ; RELOC-NEXT: Name: .bss.colliding_global1
; RELOC-NEXT: Alignment: 2 ; RELOC-NEXT: Alignment: 2
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: - Index: 1 ; RELOC-NEXT: - Index: 1
; RELOC-NEXT: Name: .bss.colliding_global2 ; RELOC-NEXT: Name: .bss.colliding_global2
; RELOC-NEXT: Alignment: 2 ; RELOC-NEXT: Alignment: 2
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines

test/wasm/lto/relocatable-undefined.ll

  • This file was added.
; RUN: llvm-as %s -o %t.o
; RUN: wasm-ld -r -o %t.wasm %t.o
; RUN: obj2yaml %t.wasm | FileCheck %s
target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown"
@missing_data = external global i32
declare i32 @missing_func() local_unnamed_addr
define i32 @foo() {
entry:
%0 = call i32 @missing_func()
%1 = load i32, i32* @missing_data, align 4
ret i32 %1
}
; CHECK: - Type: CUSTOM
; CHECK-NEXT: Name: linking
; CHECK-NEXT: Version: 2
; CHECK-NEXT: SymbolTable:
; CHECK-NEXT: - Index: 0
; CHECK-NEXT: Kind: FUNCTION
; CHECK-NEXT: Name: missing_func
; CHECK-NEXT: Flags: [ UNDEFINED ]
; CHECK-NEXT: Function: 0
; CHECK-NEXT: - Index: 1
; CHECK-NEXT: Kind: FUNCTION
; CHECK-NEXT: Name: foo
; CHECK-NEXT: Flags: [ ]
; CHECK-NEXT: Function: 1
; CHECK-NEXT: - Index: 2
; CHECK-NEXT: Kind: DATA
; CHECK-NEXT: Name: missing_data
; CHECK-NEXT: Flags: [ UNDEFINED ]

test/wasm/weak-alias.ll

Show First 20 Lines • Show All 181 Lines • ▼ Show 20 Lines
; RELOC-NEXT: Segments: ; RELOC-NEXT: Segments:
; RELOC-NEXT: - Offset: ; RELOC-NEXT: - Offset:
; RELOC-NEXT: Opcode: I32_CONST ; RELOC-NEXT: Opcode: I32_CONST
; RELOC-NEXT: Value: 1 ; RELOC-NEXT: Value: 1
; RELOC-NEXT: Functions: [ 1 ] ; RELOC-NEXT: Functions: [ 1 ]
; RELOC-NEXT: - Type: CODE ; RELOC-NEXT: - Type: CODE
; RELOC-NEXT: Relocations: ; RELOC-NEXT: Relocations:
; RELOC-NEXT: - Type: R_WEBASSEMBLY_FUNCTION_INDEX_LEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_FUNCTION_INDEX_LEB
; RELOC-NEXT: Index: 4 ; RELOC-NEXT: Index: 1
; RELOC-NEXT: Offset: 0x00000004 ; RELOC-NEXT: Offset: 0x00000004
; RELOC-NEXT: - Type: R_WEBASSEMBLY_FUNCTION_INDEX_LEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_FUNCTION_INDEX_LEB
; RELOC-NEXT: Index: 1 ; RELOC-NEXT: Index: 2
; RELOC-NEXT: Offset: 0x00000013 ; RELOC-NEXT: Offset: 0x00000013
; RELOC-NEXT: - Type: R_WEBASSEMBLY_FUNCTION_INDEX_LEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_FUNCTION_INDEX_LEB
; RELOC-NEXT: Index: 4 ; RELOC-NEXT: Index: 1
; RELOC-NEXT: Offset: 0x0000001C ; RELOC-NEXT: Offset: 0x0000001C
; RELOC-NEXT: - Type: R_WEBASSEMBLY_GLOBAL_INDEX_LEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_GLOBAL_INDEX_LEB
; RELOC-NEXT: Index: 6 ; RELOC-NEXT: Index: 6
; RELOC-NEXT: Offset: 0x00000027 ; RELOC-NEXT: Offset: 0x00000027
; RELOC-NEXT: - Type: R_WEBASSEMBLY_GLOBAL_INDEX_LEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_GLOBAL_INDEX_LEB
; RELOC-NEXT: Index: 6 ; RELOC-NEXT: Index: 6
; RELOC-NEXT: Offset: 0x00000032 ; RELOC-NEXT: Offset: 0x00000032
; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB
; RELOC-NEXT: Index: 4 ; RELOC-NEXT: Index: 1
; RELOC-NEXT: Offset: 0x0000003A ; RELOC-NEXT: Offset: 0x0000003A
; RELOC-NEXT: - Type: R_WEBASSEMBLY_FUNCTION_INDEX_LEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_FUNCTION_INDEX_LEB
; RELOC-NEXT: Index: 4 ; RELOC-NEXT: Index: 1
; RELOC-NEXT: Offset: 0x00000043 ; RELOC-NEXT: Offset: 0x00000043
; RELOC-NEXT: - Type: R_WEBASSEMBLY_GLOBAL_INDEX_LEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_GLOBAL_INDEX_LEB
; RELOC-NEXT: Index: 6 ; RELOC-NEXT: Index: 6
; RELOC-NEXT: Offset: 0x00000050 ; RELOC-NEXT: Offset: 0x00000050
; RELOC-NEXT: - Type: R_WEBASSEMBLY_GLOBAL_INDEX_LEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_GLOBAL_INDEX_LEB
; RELOC-NEXT: Index: 6 ; RELOC-NEXT: Index: 6
; RELOC-NEXT: Offset: 0x0000005D ; RELOC-NEXT: Offset: 0x0000005D
; RELOC-NEXT: - Type: R_WEBASSEMBLY_GLOBAL_INDEX_LEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_GLOBAL_INDEX_LEB
; RELOC-NEXT: Index: 6 ; RELOC-NEXT: Index: 6
; RELOC-NEXT: Offset: 0x00000068 ; RELOC-NEXT: Offset: 0x00000068
; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_TABLE_INDEX_SLEB
; RELOC-NEXT: Index: 1 ; RELOC-NEXT: Index: 2
; RELOC-NEXT: Offset: 0x00000070 ; RELOC-NEXT: Offset: 0x00000070
; RELOC-NEXT: - Type: R_WEBASSEMBLY_FUNCTION_INDEX_LEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_FUNCTION_INDEX_LEB
; RELOC-NEXT: Index: 1 ; RELOC-NEXT: Index: 2
; RELOC-NEXT: Offset: 0x00000079 ; RELOC-NEXT: Offset: 0x00000079
; RELOC-NEXT: - Type: R_WEBASSEMBLY_GLOBAL_INDEX_LEB ; RELOC-NEXT: - Type: R_WEBASSEMBLY_GLOBAL_INDEX_LEB
; RELOC-NEXT: Index: 6 ; RELOC-NEXT: Index: 6
; RELOC-NEXT: Offset: 0x00000086 ; RELOC-NEXT: Offset: 0x00000086
; RELOC-NEXT: Functions: ; RELOC-NEXT: Functions:
; RELOC-NEXT: - Index: 0 ; RELOC-NEXT: - Index: 0
; RELOC-NEXT: Locals: ; RELOC-NEXT: Locals:
; RELOC-NEXT: Body: 1081808080001A0B ; RELOC-NEXT: Body: 1081808080001A0B
Show All 22 Lines
; RELOC-NEXT: SymbolTable: ; RELOC-NEXT: SymbolTable:
; RELOC-NEXT: - Index: 0 ; RELOC-NEXT: - Index: 0
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: _start ; RELOC-NEXT: Name: _start
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 0 ; RELOC-NEXT: Function: 0
; RELOC-NEXT: - Index: 1 ; RELOC-NEXT: - Index: 1
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: alias_fn
; RELOC-NEXT: Flags: [ BINDING_WEAK ]
; RELOC-NEXT: Function: 1
; RELOC-NEXT: - Index: 2
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: direct_fn ; RELOC-NEXT: Name: direct_fn
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 1 ; RELOC-NEXT: Function: 1
; RELOC-NEXT: - Index: 2 ; RELOC-NEXT: - Index: 3
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: call_direct ; RELOC-NEXT: Name: call_direct
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 2 ; RELOC-NEXT: Function: 2
; RELOC-NEXT: - Index: 3 ; RELOC-NEXT: - Index: 4
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: call_alias ; RELOC-NEXT: Name: call_alias
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 3 ; RELOC-NEXT: Function: 3
; RELOC-NEXT: - Index: 4
; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: alias_fn
; RELOC-NEXT: Flags: [ BINDING_WEAK ]
; RELOC-NEXT: Function: 1
; RELOC-NEXT: - Index: 5 ; RELOC-NEXT: - Index: 5
; RELOC-NEXT: Kind: FUNCTION ; RELOC-NEXT: Kind: FUNCTION
; RELOC-NEXT: Name: call_alias_ptr ; RELOC-NEXT: Name: call_alias_ptr
; RELOC-NEXT: Flags: [ ] ; RELOC-NEXT: Flags: [ ]
; RELOC-NEXT: Function: 4 ; RELOC-NEXT: Function: 4
; RELOC-NEXT: - Index: 6 ; RELOC-NEXT: - Index: 6
; RELOC-NEXT: Kind: GLOBAL ; RELOC-NEXT: Kind: GLOBAL
; RELOC-NEXT: Name: __stack_pointer ; RELOC-NEXT: Name: __stack_pointer
Show All 23 Lines

wasm/Writer.cpp

Show First 20 Lines • Show All 896 Lines • ▼ Show 20 Lines
} }
void Writer::assignSymtab() { void Writer::assignSymtab() {
if (!Config->Relocatable) if (!Config->Relocatable)
return; return;
StringMap<uint32_t> SectionSymbolIndices; StringMap<uint32_t> SectionSymbolIndices;
unsigned SymbolIndex = SymtabEntries.size(); unsigned SymbolIndex = SymtabEntries.size();
pccUnsubmitted
Done
ReplyInline Actions

Maybe this would be better as

for (Symbol *Sym : Symtab->getSymbols()) {
  // handle global symbols
}

for (ObjFile *File : Symtab->ObjectFiles) {
  for (Symbol *Sym : File->getSymbols()) {
    if (!Sym->isLocal())
      continue;
    // handle local/section symbols
  }
}

? I believe that's how we handle .symtab in ELF for example.

pcc: Maybe this would be better as ``` for (Symbol *Sym : Symtab->getSymbols()) { // handle…
for (ObjFile *File : Symtab->ObjectFiles) {
LLVM_DEBUG(dbgs() << "Symtab entries: " << File->getName() << "\n");
for (Symbol *Sym : File->getSymbols()) {
if (Sym->getFile() != File)
continue;
auto AddSymbol = [&](Symbol* Sym) {
ruiuUnsubmitted
Not Done
ReplyInline Actions

Symbol* -> Symbol *

ruiu: `Symbol*` -> `Symbol *`
if (auto *S = dyn_cast<SectionSymbol>(Sym)) { if (auto *S = dyn_cast<SectionSymbol>(Sym)) {
StringRef Name = S->getName(); StringRef Name = S->getName();
if (CustomSectionMapping.count(Name) == 0) if (CustomSectionMapping.count(Name) == 0)
continue; return;
auto SSI = SectionSymbolIndices.find(Name); auto SSI = SectionSymbolIndices.find(Name);
if (SSI != SectionSymbolIndices.end()) { if (SSI != SectionSymbolIndices.end()) {
Sym->setOutputSymbolIndex(SSI->second); Sym->setOutputSymbolIndex(SSI->second);
continue; return;
} }
SectionSymbolIndices[Name] = SymbolIndex; SectionSymbolIndices[Name] = SymbolIndex;
CustomSectionSymbols[Name] = cast<SectionSymbol>(Sym); CustomSectionSymbols[Name] = cast<SectionSymbol>(Sym);
Sym->markLive(); Sym->markLive();
} }
// (Since this is relocatable output, GC is not performed so symbols must // (Since this is relocatable output, GC is not performed so symbols must
// be live.) // be live.)
assert(Sym->isLive()); assert(Sym->isLive());
Sym->setOutputSymbolIndex(SymbolIndex++); Sym->setOutputSymbolIndex(SymbolIndex++);
SymtabEntries.emplace_back(Sym); SymtabEntries.emplace_back(Sym);
} };
}
for (Symbol *Sym : Symtab->getSymbols())
if (!Sym->isLazy())
AddSymbol(Sym);
// For the moment, relocatable output doesn't contain any synthetic functions, for (ObjFile *File : Symtab->ObjectFiles) {
// so no need to look through the Symtab for symbols not referenced by LLVM_DEBUG(dbgs() << "Local symtab entries: " << File->getName() << "\n");
// Symtab->ObjectFiles. for (Symbol *Sym : File->getSymbols())
if (Sym->isLocal())
AddSymbol(Sym);
}
} }
uint32_t Writer::lookupType(const WasmSignature &Sig) { uint32_t Writer::lookupType(const WasmSignature &Sig) {
auto It = TypeIndices.find(Sig); auto It = TypeIndices.find(Sig);
if (It == TypeIndices.end()) { if (It == TypeIndices.end()) {
error("type not found: " + toString(Sig)); error("type not found: " + toString(Sig));
return 0; return 0;
} }
▲ Show 20 Lines • Show All 299 Lines • Show Last 20 Lines