Page MenuHomePhabricator

[AMDGPU][MC][GFX8+][DISASSEMBLER] Corrected 1/2pi value for 64-bit operands
ClosedPublic

Authored by dp on Jan 16 2019, 9:39 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

dp created this revision.Jan 16 2019, 9:39 AM
artem.tamazov requested changes to this revision.Jan 17 2019, 4:59 AM
artem.tamazov added inline comments.
lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp
494 ↗(On Diff #182076)

0.15915494309189532 shall be enough to represent 1/2pi in 64-bit ieee-754 fp number (raw representation is 0x3FC45F306DC9C882)

This revision now requires changes to proceed.Jan 17 2019, 4:59 AM
dp updated this revision to Diff 182265.Jan 17 2019, 5:59 AM

Thanks! Corrected.

This revision is now accepted and ready to land.Jan 17 2019, 6:25 AM
This revision was automatically updated to reflect the committed changes.