This is an archive of the discontinued LLVM Phabricator instance.

Differential D56755

[lldb-mi] Remove use of dialog box
ClosedPublic

Authored by xiaobai on Jan 15 2019, 4:03 PM.

Details

Reviewers
zturner
jingham
compnerd
Commits
rGf510bc797241: [lldb-mi] Remove use of dialog box
rLLDB351276: [lldb-mi] Remove use of dialog box
rL351276: [lldb-mi] Remove use of dialog box
Summary

This really is only implemented on Windows, and it requires us to pull
in User32. This was only useful when debugging on lldb-mi on Windows, and there
doesn't seem to be a good reason why using a dialog box is better than what
exists for other platforms.

Diff Detail

Repository
rL LLVM

Event Timeline

xiaobai created this revision.Jan 15 2019, 4:03 PM
Herald added a subscriber: ki.stfu. · View Herald TranscriptJan 15 2019, 4:03 PM
Harbormaster completed remote builds in B26883: Diff 181914.Jan 15 2019, 4:03 PM
xiaobai mentioned this in D56741: [CMake] Explicitly list User32 as dependency of lldb-mi.Jan 15 2019, 4:03 PM
jingham accepted this revision.Jan 15 2019, 4:06 PM

LGTM

This revision is now accepted and ready to land.Jan 15 2019, 4:06 PM
Closed by commit rL351276: [lldb-mi] Remove use of dialog box (authored by xiaobai). · Explain WhyJan 15 2019, 4:13 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 15 2019, 4:13 PM

Revision Contents

PathSize
lldb/
trunk/
tools/
lldb-mi/
4 lines
1 line
19 lines

Diff 181921

lldb/trunk/tools/lldb-mi/MIDriverMain.cpp

Show First 20 Lines • Show All 159 Lines • ▼ Show 20 Lines
// <0 = Program failed. // <0 = Program failed.
// -1 = Program failed reason not specified here, see MI log // -1 = Program failed reason not specified here, see MI log
// file. // file.
// -1000 = Program failed did not initialize successfully. // -1000 = Program failed did not initialize successfully.
// Throws: None. // Throws: None.
//-- //--
int main(int argc, char const *argv[]) { int main(int argc, char const *argv[]) {
#if MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG #if MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG
#ifdef _WIN32
CMIUtilDebug::ShowDlgWaitForDbgAttach();
#else
CMIUtilDebug::WaitForDbgAttachInfinteLoop(); CMIUtilDebug::WaitForDbgAttachInfinteLoop();
#endif // _WIN32
#endif // MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG #endif // MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG
llvm::StringRef ToolName = argv[0]; llvm::StringRef ToolName = argv[0];
llvm::sys::PrintStackTraceOnErrorSignal(ToolName); llvm::sys::PrintStackTraceOnErrorSignal(ToolName);
llvm::PrettyStackTraceProgram X(argc, argv); llvm::PrettyStackTraceProgram X(argc, argv);
// *** Order is important here *** // *** Order is important here ***
bool bOk = DriverSystemInit(); bool bOk = DriverSystemInit();
Show All 23 Lines

lldb/trunk/tools/lldb-mi/MIUtilDebug.h

Show All 18 Lines
//++ //++
//============================================================================ //============================================================================
// Details: MI debugging aid utility class. // Details: MI debugging aid utility class.
//-- //--
class CMIUtilDebug { class CMIUtilDebug {
// Statics: // Statics:
public: public:
static void ShowDlgWaitForDbgAttach();
static void WaitForDbgAttachInfinteLoop(); static void WaitForDbgAttachInfinteLoop();
// Methods: // Methods:
public: public:
/* ctor */ CMIUtilDebug(); /* ctor */ CMIUtilDebug();
// Overrideable: // Overrideable:
public: public:
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines

lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp

Show All 33 Lines
// Args: None. // Args: None.
// Return: None. // Return: None.
// Throws: None. // Throws: None.
//-- //--
CMIUtilDebug::~CMIUtilDebug() {} CMIUtilDebug::~CMIUtilDebug() {}
//++ //++
//------------------------------------------------------------------------------------ //------------------------------------------------------------------------------------
// Details: Show a dialog to the process/application halts. It gives the
// opportunity to
// attach a debugger.
// Type: Static method.
// Args: None.
// Return: None.
// Throws: None.
//--
void CMIUtilDebug::ShowDlgWaitForDbgAttach() {
const CMIUtilString strCaption(CMIDriver::Instance().GetAppNameShort());
#ifdef _WIN32
::MessageBoxA(NULL, "Attach your debugger now", strCaption.c_str(), MB_OK);
#else
// ToDo: Implement other platform version of an Ok to continue dialog box
#endif // _WIN32
}
//++
//------------------------------------------------------------------------------------
// Details: Temporarily stall the process/application to give the programmer the // Details: Temporarily stall the process/application to give the programmer the
// opportunity to attach a debugger. How to use: Put a break in the // opportunity to attach a debugger. How to use: Put a break in the
// programmer // programmer
// where you want to visit, run the application then attach your // where you want to visit, run the application then attach your
// debugger to the // debugger to the
// application. Hit the debugger's pause button and the debugger should // application. Hit the debugger's pause button and the debugger should
// should // should
// show this loop. Change the i variable value to break out of the loop // show this loop. Change the i variable value to break out of the loop
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines