This is an archive of the discontinued LLVM Phabricator instance.

Differential D56704

gn build: Switch to using current_os in lib/Support/BUILD.gn.
ClosedPublic

Authored by pcc on Jan 14 2019, 9:09 PM.

Details

Reviewers
thakis
phosek
Commits
rGa22ebe483b87: gn build: Switch to using current_os in lib/Support/BUILD.gn.
rL351166: gn build: Switch to using current_os in lib/Support/BUILD.gn.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc created this revision.Jan 14 2019, 9:09 PM
Herald added subscribers: kristina, hiraditya, srhines. · View Herald TranscriptJan 14 2019, 9:09 PM
Harbormaster completed remote builds in B26836: Diff 181716.Jan 14 2019, 9:09 PM
phosek accepted this revision.Jan 14 2019, 10:57 PM

LGTM

This revision is now accepted and ready to land.Jan 14 2019, 10:57 PM
Closed by commit rL351166: gn build: Switch to using current_os in lib/Support/BUILD.gn. (authored by pcc). · Explain WhyJan 14 2019, 11:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
utils/
gn/
secondary/
llvm/
lib/
Support/
2 lines

Diff 181728

llvm/trunk/utils/gn/secondary/llvm/lib/Support/BUILD.gn

Show First 20 Lines • Show All 149 Lines • ▼ Show 20 Lines sources = [
"Threading.cpp", "Threading.cpp",
"Valgrind.cpp", "Valgrind.cpp",
"VirtualFileSystem.cpp", "VirtualFileSystem.cpp",
"Watchdog.cpp", "Watchdog.cpp",
] ]
libs = [] libs = []
if (host_os == "linux") { if (current_os == "linux" || current_os == "android") {
libs += [ "dl" ] libs += [ "dl" ]
} }
} }