This is an archive of the discontinued LLVM Phabricator instance.

Differential D56687

[WebAssembly] Changed objdump output to offsets instead of indices (NFC).
ClosedPublic

Authored by aardappel on Jan 14 2019, 4:14 PM.

Details

Reviewers
sbc100
Commits
rG7ab15a79be11: [WebAssembly] Changed objdump output to offsets instead of indices.
rLLD351462: [WebAssembly] Changed objdump output to offsets instead of indices.
rL351462: [WebAssembly] Changed objdump output to offsets instead of indices.
Summary

This is to accommodate this change: https://reviews.llvm.org/D56684

Diff Detail

Repository
rL LLVM

Event Timeline

aardappel created this revision.Jan 14 2019, 4:14 PM
Herald added subscribers: llvm-commits, sunfish, aheejin and 2 others. · View Herald TranscriptJan 14 2019, 4:14 PM
Harbormaster completed remote builds in B26817: Diff 181664.Jan 14 2019, 4:14 PM
sbc100 accepted this revision.Jan 14 2019, 4:46 PM

You can add " NFC" to the end of this CL description.

This revision is now accepted and ready to land.Jan 14 2019, 4:46 PM
aardappel retitled this revision from [WebAssembly] Changed objdump output to offsets instead of indices. to [WebAssembly] Changed objdump output to offsets instead of indices (NFC)..Jan 14 2019, 5:17 PM
Closed by commit rL351462: [WebAssembly] Changed objdump output to offsets instead of indices. (authored by aardappel). · Explain WhyJan 17 2019, 10:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
test/
wasm/
6 lines

Diff 182340

lld/trunk/test/wasm/archive.ll

Show All 27 Lines
} }
; Verify that mutually dependant object files in an archive is handled ; Verify that mutually dependant object files in an archive is handled
; correctly. Since we're using llvm-nm, we must link with --relocatable. ; correctly. Since we're using llvm-nm, we must link with --relocatable.
; ;
; TODO(ncw): Update LLD so that the symbol table is written out for ; TODO(ncw): Update LLD so that the symbol table is written out for
; non-relocatable output (with an option to strip it) ; non-relocatable output (with an option to strip it)
; CHECK: 00000004 T _start ; CHECK: 00000016 T _start
; CHECK-NEXT: 00000002 T archive2_symbol ; CHECK-NEXT: 0000000a T archive2_symbol
; CHECK-NEXT: 00000001 T bar ; CHECK-NEXT: 00000001 T bar
; CHECK-NEXT: 00000003 T foo ; CHECK-NEXT: 0000000d T foo
; CHECK-NEXT: U missing_func ; CHECK-NEXT: U missing_func
; Verify that symbols from unused objects don't appear in the symbol table ; Verify that symbols from unused objects don't appear in the symbol table
; CHECK-NOT: hello ; CHECK-NOT: hello
; Specifying the same archive twice is allowed. ; Specifying the same archive twice is allowed.
; RUN: wasm-ld %t.a %t.a %t.o -o %t.wasm ; RUN: wasm-ld %t.a %t.a %t.o -o %t.wasm
; Verfiy errors include library name ; Verfiy errors include library name
; RUN: not wasm-ld -u archive2_symbol -u archive3_symbol %t.a %t.o -o %t.wasm 2>&1 | FileCheck -check-prefix=CHECK-DUP %s ; RUN: not wasm-ld -u archive2_symbol -u archive3_symbol %t.a %t.o -o %t.wasm 2>&1 | FileCheck -check-prefix=CHECK-DUP %s
; CHECK-DUP: error: duplicate symbol: bar ; CHECK-DUP: error: duplicate symbol: bar
; CHECK-DUP: >>> defined in {{.*}}.a({{.*}}.a2.o) ; CHECK-DUP: >>> defined in {{.*}}.a({{.*}}.a2.o)
; CHECK-DUP: >>> defined in {{.*}}.a({{.*}}.a3.o) ; CHECK-DUP: >>> defined in {{.*}}.a({{.*}}.a3.o)