Details
Details
- Reviewers
sammccall - Commits
- rGa4cf26b499fd: [clangd] Penalize file-scope symbols in the ranking for non-completion queries
rL352868: [clangd] Penalize file-scope symbols in the ranking for non-completion queries
rCTE352868: [clangd] Penalize file-scope symbols in the ranking for non-completion queries
Diff Detail
Diff Detail
- Build Status
Buildable 26885 Build 26884: arc lint + arc unit
Event Timeline
clang-tools-extra/clangd/Quality.cpp | ||
---|---|---|
289 | (needs update after I inverted this flag to VisibleOutsideFile, sorry!) | |
385 | I'd suggest being a bit more aggressive here: 0.5 or 0.4. Just guessing though, up to you. | |
clang-tools-extra/unittests/clangd/QualityTests.cpp | ||
104 | can you add a main-file symbol here, and verify the scope property gets set on the SymbolRelevanceSignals correctly? |
(needs update after I inverted this flag to VisibleOutsideFile, sorry!)