Page MenuHomePhabricator

[CMake] Remove dead code and outdated comments
ClosedPublic

Authored by sgraenitz on Jan 11 2019, 9:35 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sgraenitz created this revision.Jan 11 2019, 9:35 AM
stella.stamenova accepted this revision.Jan 11 2019, 9:45 AM
This revision is now accepted and ready to land.Jan 11 2019, 9:45 AM
sgraenitz marked 2 inline comments as done.Jan 11 2019, 9:50 AM

Simple cleanup parts of the previous reviews D56400 and D56440

lit/CMakeLists.txt
21 ↗(On Diff #181299)

This only changes the value of LLDB_TEST_C/CXX_COMPILER in the scope this file. It is unused since https://reviews.llvm.org/rC347216#change-H2HV4zA8ol05 removed their usage from lit/lit.site.cfg.py.in (which gets configured below). Before this change the local value was passed to the config file like this:

config.cc = "@LLDB_TEST_C_COMPILER@"
config.cxx = "@LLDB_TEST_CXX_COMPILER@"

They seem to be inferred via LLDB_LIT_TOOLS_DIR now.

51 ↗(On Diff #181299)

LLDB_HAVE_LLD was only used between r331447 and r347216.
ENABLE_SHARED was only used between r232205 and r232227.

Closed by commit rL350937: [CMake] Remove dead code and outdated comments (authored by stefan.graenitz, committed by ). · Explain WhyJan 11 2019, 9:55 AM
This revision was automatically updated to reflect the committed changes.
labath added inline comments.Jan 14 2019, 4:25 AM
lldb/trunk/cmake/modules/LLDBStandalone.cmake
104

If this comment is outdated, does that mean the if (EXISTS) can be removed too?