This is an archive of the discontinued LLVM Phabricator instance.

Differential D56472

Change test/tools/lto/no-bitcode.s requirement from arm to aarch64
ClosedPublic

Authored by easyaspi314 on Jan 8 2019, 7:17 PM.

Details

Reviewers
RKSimon
craig.topper
MaskRay
dmgreen
Commits
rGfbca7094c934: [LTO] Change test/tools/lto/no-bitcode.s requirement from arm to aarch64
rL351560: [LTO] Change test/tools/lto/no-bitcode.s requirement from arm to aarch64
Summary

Set the test to properly require aarch64 instead of arm. Otherwise, this test fails with LLVM_TARGETS_TO_BUILD='ARM;X86'

bin/llvm-mc: : error: unable to get target for 'arm64-apple-ios7.0.0'

Diff Detail

Repository
rL LLVM

Event Timeline

easyaspi314 created this revision.Jan 8 2019, 7:17 PM
Herald added subscribers: llvm-commits, dexonsmith, steven_wu and 4 others. · View Herald TranscriptJan 8 2019, 7:17 PM
dmgreen accepted this revision.Jan 9 2019, 2:55 PM
dmgreen added a subscriber: dmgreen.

Looks sensible to me.

This revision is now accepted and ready to land.Jan 9 2019, 2:55 PM
MaskRay accepted this revision.Jan 13 2019, 8:17 AM
RKSimon added a comment.Jan 18 2019, 1:28 AM

@easyaspi314 do you have commit access?

easyaspi314 added a comment.Jan 18 2019, 7:48 AM

@RKSimon considering that I am a newbie, I am pretty sure I do not.

RKSimon added a comment.Jan 18 2019, 7:55 AM
In D56472#1363162, @easyaspi314 wrote:

@RKSimon considering that I am a newbie, I am pretty sure I do not.

OK, I'll commit this but you can request access here: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

If you're intending to stick around for a while then its better to get the process started!

Closed by commit rL351560: [LTO] Change test/tools/lto/no-bitcode.s requirement from arm to aarch64 (authored by RKSimon). · Explain WhyJan 18 2019, 8:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
tools/
lto/
2 lines

Diff 182522

llvm/trunk/test/tools/lto/no-bitcode.s

; REQUIRES: arm-registered-target ; REQUIRES: aarch64-registered-target
; libLTO.dylib shouldn't assert on invalid inputs. ; libLTO.dylib shouldn't assert on invalid inputs.
; RUN: llvm-mc -triple=arm64-apple-ios7.0.0 -filetype=obj -o %t.o ; RUN: llvm-mc -triple=arm64-apple-ios7.0.0 -filetype=obj -o %t.o
; RUN: llvm-ar r %t.a %t.o ; RUN: llvm-ar r %t.a %t.o
; RUN: %ld64 -lto_library %llvmshlibdir/libLTO.dylib -arch x86_64 -dylib -mllvm -O0 -o %t.dylib %t.a ; RUN: %ld64 -lto_library %llvmshlibdir/libLTO.dylib -arch x86_64 -dylib -mllvm -O0 -o %t.dylib %t.a