This is an archive of the discontinued LLVM Phabricator instance.

Differential D56456

[Driver] Default to -fno-addrsig on Android.
ClosedPublic

Authored by danalbert on Jan 8 2019, 2:24 PM.

Details

Reviewers
srhines
pirama
Commits
rGdd14234b6093: [Driver] Default to -fno-addrsig on Android.
rC350668: [Driver] Default to -fno-addrsig on Android.
rL350668: [Driver] Default to -fno-addrsig on Android.
Summary

The Android NDK still uses GNU binutils by default.

Diff Detail

Event Timeline

danalbert created this revision.Jan 8 2019, 2:24 PM
Harbormaster completed remote builds in B26528: Diff 180738.Jan 8 2019, 2:25 PM
srhines accepted this revision.Jan 8 2019, 2:28 PM
This revision is now accepted and ready to land.Jan 8 2019, 2:28 PM
Closed by commit rL350668: [Driver] Default to -fno-addrsig on Android. (authored by danalbert). · Explain WhyJan 8 2019, 2:37 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 8 2019, 2:37 PM
thakis added a subscriber: thakis.May 21 2020, 12:01 PM

Do we still need this? I was surprised by clang not using faddrsing on Andriod by default.

danalbert added a comment.May 21 2020, 12:30 PM

The NDK still supports linkers other than LLD, but we are changing the default to LLD in the next release. I'd prefer to keep this for the time being, but don't feel strongly about it.

Revision Contents

PathSize
lib/
Driver/
ToolChains/
1 line
test/
Driver/
1 line

Diff 180738

lib/Driver/ToolChains/Clang.cpp

Show First 20 Lines • Show All 5,286 Lines • ▼ Show 20 Lines
} }
if (Args.hasFlag(options::OPT_faddrsig, options::OPT_fno_addrsig, if (Args.hasFlag(options::OPT_faddrsig, options::OPT_fno_addrsig,
(TC.getTriple().isOSBinFormatELF() || (TC.getTriple().isOSBinFormatELF() ||
TC.getTriple().isOSBinFormatCOFF()) && TC.getTriple().isOSBinFormatCOFF()) &&
!TC.getTriple().isPS4() && !TC.getTriple().isPS4() &&
!TC.getTriple().isOSNetBSD() && !TC.getTriple().isOSNetBSD() &&
!Distro(D.getVFS()).IsGentoo() && !Distro(D.getVFS()).IsGentoo() &&
!TC.getTriple().isAndroid() &&
TC.useIntegratedAs())) TC.useIntegratedAs()))
CmdArgs.push_back("-faddrsig"); CmdArgs.push_back("-faddrsig");
// Finally add the compile command to the compilation. // Finally add the compile command to the compilation.
if (Args.hasArg(options::OPT__SLASH_fallback) && if (Args.hasArg(options::OPT__SLASH_fallback) &&
Output.getType() == types::TY_Object && Output.getType() == types::TY_Object &&
(InputType == types::TY_C || InputType == types::TY_CXX)) { (InputType == types::TY_C || InputType == types::TY_CXX)) {
auto CLCommand = auto CLCommand =
▲ Show 20 Lines • Show All 879 Lines • Show Last 20 Lines

test/Driver/addrsig.c

// Gentoo disables -faddrsig by default // Gentoo disables -faddrsig by default
// XFAIL: gentoo // XFAIL: gentoo
// RUN: %clang -### -target x86_64-unknown-linux -c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s // RUN: %clang -### -target x86_64-unknown-linux -c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s
// RUN: %clang -### -target x86_64-pc-win32 -c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s // RUN: %clang -### -target x86_64-pc-win32 -c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s
// RUN: %clang -### -target x86_64-unknown-linux -fno-integrated-as -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s // RUN: %clang -### -target x86_64-unknown-linux -fno-integrated-as -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s
// RUN: %clang -### -target x86_64-unknown-linux -fno-integrated-as -faddrsig -c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s // RUN: %clang -### -target x86_64-unknown-linux -fno-integrated-as -faddrsig -c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s
// RUN: %clang -### -target x86_64-unknown-linux -fno-addrsig -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s // RUN: %clang -### -target x86_64-unknown-linux -fno-addrsig -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s
// RUN: %clang -### -target x86_64-apple-darwin -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s // RUN: %clang -### -target x86_64-apple-darwin -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s
// RUN: %clang -### -target x86_64-scei-ps4 -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s // RUN: %clang -### -target x86_64-scei-ps4 -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s
// RUN: %clang -### -target x86_64-linux-android21 -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s
// ADDRSIG: -faddrsig // ADDRSIG: -faddrsig
// NO-ADDRSIG-NOT: -faddrsig // NO-ADDRSIG-NOT: -faddrsig