Page MenuHomePhabricator

ProcessLaunchInfo: Remove Target reference
ClosedPublic

Authored by labath on Wed, Jan 2, 1:43 AM.

Details

Summary

The target was being used in FinalizeFileActions to provide default
values for stdin/out/err. Also, most of the logic of this function was
very specific to how the lldb's Target class wants to launch processes,
so I, move it to Target::FinalizeFileActions, inverting the dependency.
The only piece of logic that was useful elsewhere (lldb-server) was the
part which sets up a pty and relevant file actions. I've kept this part
as ProcessLaunchInfo::SetUpPtyRedirection.

This makes ProcessLaunchInfo independent of any high-level lldb constructs.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Wed, Jan 2, 1:43 AM
clayborg accepted this revision.Wed, Jan 2, 12:56 PM
This revision is now accepted and ready to land.Wed, Jan 2, 12:56 PM
This revision was automatically updated to reflect the committed changes.