This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Disable -faddrsig on Gentoo by default
ClosedPublic

Authored by mgorny on Dec 22 2018, 1:21 AM.

Details

Summary

Gentoo supports combining clang toolchain with GNU binutils, and many
users actually do that. As -faddrsig is not supported by GNU strip,
this results in a lot of warnings. Disable it by default and let users
enable it explicitly if they want it; with the intent of reevaluating
when the underlying feature becomes standarized.

Diff Detail

Event Timeline

Just a comment regarding the description, are you sure it's GNU strip and not as?

Just a comment regarding the description, are you sure it's GNU strip and not as?

Yes. https://bugs.gentoo.org/667854

It was disabled on NetBSD for the same reason - GNU strip(1) is breaking: http://netbsd.org/~kamil/llvm/strip.txt

phosek accepted this revision.Dec 23 2018, 1:30 AM

LGTM, would it be possible to also include https://bugs.gentoo.org/667854 in the commit message for reference?

This revision is now accepted and ready to land.Dec 23 2018, 1:30 AM

LGTM, would it be possible to also include https://bugs.gentoo.org/667854 in the commit message for reference?

Done, and thanks for the review.

This revision was automatically updated to reflect the committed changes.