This is an archive of the discontinued LLVM Phabricator instance.

Differential D56004

Fix mingw build failures caused by r349839
ClosedPublic

Authored by tstellar on Dec 21 2018, 7:44 AM.

Details

Reviewers
mstorsjo
Commits
rG7dca9bbef7c0: Fix mingw build failures caused by r349839
rL349990: Fix mingw build failures caused by r349839

Diff Detail

Event Timeline

tstellar created this revision.Dec 21 2018, 7:44 AM
Herald added a subscriber: mgorny. · View Herald TranscriptDec 21 2018, 7:44 AM
Harbormaster completed remote builds in B26229: Diff 179289.Dec 21 2018, 7:44 AM
tstellar mentioned this in D55965: cmake: Don't install plugins used for examples or tests.Dec 21 2018, 7:45 AM
SquallATF edited reviewers, added: mstorsjo; removed: SquallATF.Dec 21 2018, 5:39 PM

This change can fix mingw build, but I think I don't have review permission.

tstellar added a comment.Dec 21 2018, 7:24 PM

I will push it, since you confirmed it fixes the build.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 21 2018, 7:46 PM
Closed by commit rL349990: Fix mingw build failures caused by r349839 (authored by tstellar). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cmake/
modules/
4 lines

Diff 179289

cmake/modules/AddLLVM.cmake

Show First 20 Lines • Show All 652 Lines • ▼ Show 20 Lines if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY OR ${name} STREQUAL "LTO" OR
set(install_dir bin) set(install_dir bin)
else() else()
set(install_type LIBRARY) set(install_type LIBRARY)
endif() endif()
else() else()
set(install_type ARCHIVE) set(install_type ARCHIVE)
endif() endif()
if (ARG_MODULE)
set(install_type LIBRARY)
endif()
if(${name} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR if(${name} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
NOT LLVM_DISTRIBUTION_COMPONENTS) NOT LLVM_DISTRIBUTION_COMPONENTS)
set(export_to_llvmexports EXPORT LLVMExports) set(export_to_llvmexports EXPORT LLVMExports)
set_property(GLOBAL PROPERTY LLVM_HAS_EXPORTS True) set_property(GLOBAL PROPERTY LLVM_HAS_EXPORTS True)
endif() endif()
install(TARGETS ${name} install(TARGETS ${name}
${export_to_llvmexports} ${export_to_llvmexports}
▲ Show 20 Lines • Show All 1,063 Lines • Show Last 20 Lines