Page MenuHomePhabricator

Show the memory region name if there is one in the output of the "memory region" command

Authored by clayborg on Dec 18 2018, 2:22 PM.



Prior to this change we would show the name of the section that a memory region belonged to but not its actual region name. Now we show this,. Added a test that reuses the regions-linux-map.dmp minidump file to test this and verify the correct region names for various memory regions.

Diff Detail


Event Timeline

clayborg created this revision.Dec 18 2018, 2:22 PM
labath accepted this revision.Dec 19 2018, 12:04 AM

This looks fine to me. I have one inline suggestion you can consider. Also, I've been wondering whether there is any existing minidump that you could have used for the test purposes. It doesn't sound like there is anything too special about this minidump, and it would reduce the number of binary blobs we carry around.


wouldn't self.expect be able to handle this? I would expect this can just be a series of self.expect("memory region XXX", substrs = ["/system/lib/"]) commands.

This revision is now accepted and ready to land.Dec 19 2018, 12:04 AM
This revision was automatically updated to reflect the committed changes.