lemo (Leonard Mosescu)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2017, 12:48 PM (45 w, 2 d)

Recent Activity

Tue, Jul 17

lemo added a comment to D49202: Restructure the minidump loading path and add early & explicit consistency checks.

Great timing! ARM support would be most welcome. Are you planning to
support the Breakpad flavor or ARM minidumps or the Microsoft one? (Mark
Mentovai just reminded me that the ARM support was added independently and
some of the structures are different)

Tue, Jul 17, 11:16 AM · Restricted Project

Mon, Jul 16

lemo updated subscribers of D49202: Restructure the minidump loading path and add early & explicit consistency checks.

The problem is not returning an error from Minidump::Create() - if that was
the case this could easily be improved indeed. The two-phase initialization
is a consequence of the LLDB plugin lookup:

Mon, Jul 16, 10:16 AM · Restricted Project

Thu, Jul 12

lemo committed rL336918: Restructure the minidump loading path and add early & explicit consistency….
Restructure the minidump loading path and add early & explicit consistency…
Thu, Jul 12, 10:32 AM
lemo closed D49202: Restructure the minidump loading path and add early & explicit consistency checks.
Thu, Jul 12, 10:32 AM · Restricted Project
lemo added a comment to D49202: Restructure the minidump loading path and add early & explicit consistency checks.

Thanks Adrian for the thorough review.

Thu, Jul 12, 9:47 AM · Restricted Project

Wed, Jul 11

lemo updated the diff for D49202: Restructure the minidump loading path and add early & explicit consistency checks.
Wed, Jul 11, 4:16 PM · Restricted Project
lemo updated the diff for D49202: Restructure the minidump loading path and add early & explicit consistency checks.

Adding a few ill-formed minidumps for testing the new checks

Wed, Jul 11, 3:57 PM · Restricted Project
lemo added a comment to D49202: Restructure the minidump loading path and add early & explicit consistency checks.

Regarding test for the other checks, I'll try to fabricate a few invalid minidumps (although it would obviously provide limited coverage)

Wed, Jul 11, 3:33 PM · Restricted Project
lemo added inline comments to D49202: Restructure the minidump loading path and add early & explicit consistency checks.
Wed, Jul 11, 2:55 PM · Restricted Project
lemo updated the diff for D49202: Restructure the minidump loading path and add early & explicit consistency checks.

Incorporating CR feedback

Wed, Jul 11, 2:55 PM · Restricted Project
lemo created D49202: Restructure the minidump loading path and add early & explicit consistency checks.
Wed, Jul 11, 1:03 PM · Restricted Project

Fri, Jun 22

lemo added a comment to D48479: Represent invalid UUIDs as UUIDs with length zero.

I'm not sure if there is a suitable place for that function. This is
needed in "ObjectFileMachO" and two dynamic loader plugins.

Fri, Jun 22, 12:54 PM
lemo updated subscribers of D48479: Represent invalid UUIDs as UUIDs with length zero.

However, during parsing you need to know the meaning of a "0000...0" UUID.
In a MachO file (at least based on the comments in the code) this value is
used to denote the fact that the object file has no UUID. For elf, a
"000..0" build-id is a perfectly valid identifier (and the lack of a
build-id is denoted by the absence of the build-id section). The extra
constructor argument is my way of trying to support both scenarios. The
other possibility I see is to have a some kind of a factory function for
one of the options (or both). I don't really have a preference between the
two.

Fri, Jun 22, 12:19 PM
lemo added a comment to D48479: Represent invalid UUIDs as UUIDs with length zero.

The slight complication here is that
some clients (MachO) actually use the all-zero notation to mean "no UUID
has been set". To keep this use case working, I have introduced an
additional argument to the UUID constructor, which specifies whether an
all-zero vector should be considered a valid UUID. For the usages where
the UUID data comes from a MachO file, I set this argument to false.

Fri, Jun 22, 10:52 AM

Jun 20 2018

lemo created D48381: WIP: arbitrary-size UUIDs.
Jun 20 2018, 10:56 AM

Jun 13 2018

lemo added a comment to D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails.

The intention in the scope of this change is just to check that the new
overload is exposed correctly through the Python API.

Jun 13 2018, 10:40 AM

Jun 11 2018

lemo updated subscribers of D47991: Improve SBThread's stepping API using SBError parameter..

Ah I see. That's because the last argument is a C++ default argument. It
looks like the convention in this file is that the error argument should be
the last non-defaulted argument.

Jun 11 2018, 7:36 PM
lemo committed rL334439: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails.
Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails
Jun 11 2018, 2:24 PM
lemo closed D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails.
Jun 11 2018, 2:23 PM
lemo added a comment to D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails.

spaces removed :)

Jun 11 2018, 2:19 PM
lemo updated the diff for D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails.
Jun 11 2018, 2:19 PM
lemo updated the diff for D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails.
Jun 11 2018, 2:18 PM
lemo updated subscribers of D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails.

remove space before (

Jun 11 2018, 2:01 PM
lemo updated the diff for D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails.

Adding test cases for the new overload.

Jun 11 2018, 1:39 PM
lemo created D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails.
Jun 11 2018, 1:26 PM
lemo added inline comments to D47991: Improve SBThread's stepping API using SBError parameter..
Jun 11 2018, 10:31 AM

Jun 8 2018

lemo added a comment to D47708: PDB support of function-level linking and splitted functions.

I agree, checked in binaries are not always pretty. But some coverage
depends checked in binaries (or at very least is dramatically harder to get
the same thing from source)

Jun 8 2018, 10:10 AM
lemo updated subscribers of D47708: PDB support of function-level linking and splitted functions.

Doesn't the LIT based test drop the split-function case (originally
produced with PGO)?

Jun 8 2018, 10:03 AM

May 2 2018

lemo committed rL331394: Use the UUID from the minidump's CodeView Record for placeholder modules.
Use the UUID from the minidump's CodeView Record for placeholder modules
May 2 2018, 1:10 PM
lemo closed D46292: Use the UUID from the minidump's CodeView Record for placeholder modules.
May 2 2018, 1:09 PM · Restricted Project
lemo added inline comments to D46292: Use the UUID from the minidump's CodeView Record for placeholder modules.
May 2 2018, 10:18 AM · Restricted Project

May 1 2018

lemo updated the diff for D46292: Use the UUID from the minidump's CodeView Record for placeholder modules.
May 1 2018, 2:36 PM · Restricted Project
lemo added inline comments to D46292: Use the UUID from the minidump's CodeView Record for placeholder modules.
May 1 2018, 2:36 PM · Restricted Project
lemo added a comment to D46292: Use the UUID from the minidump's CodeView Record for placeholder modules.

Thanks for the feedback. I uploaded a new revision (incorporating some of the feedback, including an ELF test case)

May 1 2018, 11:01 AM · Restricted Project
lemo updated the diff for D46292: Use the UUID from the minidump's CodeView Record for placeholder modules.
May 1 2018, 11:00 AM · Restricted Project

Apr 30 2018

lemo created D46292: Use the UUID from the minidump's CodeView Record for placeholder modules.
Apr 30 2018, 3:25 PM · Restricted Project

Apr 24 2018

lemo updated subscribers of D45628: [LLDB] Support GNU-style compressed debug sections (.zdebug).

Hi Erik, the review is still marked as requiring changes. Once that is
sorted out I'd be happy to submit this on your behalf (what is the base SVN
revision for the latest patch?)

Apr 24 2018, 2:46 PM · Restricted Project

Apr 19 2018

lemo updated subscribers of D45700: Improve LLDB's handling of non-local minidumps.

It looks like nobody except me is worried about the
module-without-an-object-file situation, so I guess we can try this out and
see how it goes.

Apr 19 2018, 9:55 AM · Restricted Project

Apr 18 2018

lemo committed rL330302: Improve LLDB's handling of non-local minidumps.
Improve LLDB's handling of non-local minidumps
Apr 18 2018, 4:14 PM
lemo closed D45700: Improve LLDB's handling of non-local minidumps.
Apr 18 2018, 4:14 PM · Restricted Project
lemo updated subscribers of D45700: Improve LLDB's handling of non-local minidumps.

Greg/Pavel, does the latest revision look good to you? Thanks!

Apr 18 2018, 1:10 PM · Restricted Project
lemo added a comment to D45700: Improve LLDB's handling of non-local minidumps.

LGTM, but consider highlighting the side effect to target when the factory makes a Placeholder module.

Apr 18 2018, 10:31 AM · Restricted Project
lemo updated the diff for D45700: Improve LLDB's handling of non-local minidumps.
Apr 18 2018, 10:27 AM · Restricted Project

Apr 17 2018

lemo added inline comments to D45700: Improve LLDB's handling of non-local minidumps.
Apr 17 2018, 12:09 PM · Restricted Project
lemo added inline comments to D45700: Improve LLDB's handling of non-local minidumps.
Apr 17 2018, 10:55 AM · Restricted Project
lemo updated the diff for D45700: Improve LLDB's handling of non-local minidumps.

Thanks for the feedback.

Apr 17 2018, 10:44 AM · Restricted Project

Apr 16 2018

lemo updated the diff for D45700: Improve LLDB's handling of non-local minidumps.
Apr 16 2018, 3:13 PM · Restricted Project
lemo added inline comments to D45700: Improve LLDB's handling of non-local minidumps.
Apr 16 2018, 3:05 PM · Restricted Project
lemo updated the summary of D45700: Improve LLDB's handling of non-local minidumps.
Apr 16 2018, 2:17 PM · Restricted Project
lemo created D45700: Improve LLDB's handling of non-local minidumps.
Apr 16 2018, 2:15 PM · Restricted Project

Oct 23 2017

lemo added inline comments to D39199: [lldbtests] Handle errors instead of crashing.
Oct 23 2017, 11:53 AM

Oct 5 2017

lemo committed rL315037: Implement interactive command interruption.
Implement interactive command interruption
Oct 5 2017, 4:43 PM
lemo closed D37923: Implement interactive command interruption by committing rL315037: Implement interactive command interruption.
Oct 5 2017, 4:43 PM
lemo requested review of D37923: Implement interactive command interruption.
Oct 5 2017, 2:53 PM
lemo reopened D37923: Implement interactive command interruption.
Oct 5 2017, 2:53 PM
lemo updated the diff for D37923: Implement interactive command interruption.

Updating the original changes to handle reentrant calls to CommandInterpreter::IOHandlerInputComplete().

Oct 5 2017, 2:49 PM

Oct 4 2017

lemo committed rL314929: LLDB cmake fix: define LLDB_CONFIGURATION_xxx based on the build type.
LLDB cmake fix: define LLDB_CONFIGURATION_xxx based on the build type
Oct 4 2017, 1:25 PM
lemo closed D38552: LLDB cmake fix: define LLDB_CONFIGURATION_xxx based on the build type by committing rL314929: LLDB cmake fix: define LLDB_CONFIGURATION_xxx based on the build type.
Oct 4 2017, 1:25 PM
lemo updated the diff for D38552: LLDB cmake fix: define LLDB_CONFIGURATION_xxx based on the build type.

Changed how CMAKE_BUILD_TYPE is tested to ensure we default to LLDB_CONFIGURATION_DEBUG.

Oct 4 2017, 11:15 AM
lemo added a comment to D38552: LLDB cmake fix: define LLDB_CONFIGURATION_xxx based on the build type.

Good point, I wouldn't be surprised if that was the case at some point, but right now the main llvm CMakeLists.txt has this:

Oct 4 2017, 11:08 AM
lemo updated the summary of D38552: LLDB cmake fix: define LLDB_CONFIGURATION_xxx based on the build type.
Oct 4 2017, 10:53 AM
lemo created D38552: LLDB cmake fix: define LLDB_CONFIGURATION_xxx based on the build type.
Oct 4 2017, 10:50 AM

Oct 3 2017

lemo committed rL314856: updating svn:ignore.
updating svn:ignore
Oct 3 2017, 3:31 PM

Sep 20 2017

lemo updated the diff for D37923: Implement interactive command interruption.
  1. Added SB APIs (SBCommandInterpreter::WasInterrupted()). This allows python commands to query for interrupt requests.
Sep 20 2017, 2:36 PM

Sep 19 2017

lemo added a comment to D37923: Implement interactive command interruption.

Ping? Are there any more open questions or unresolved comments or is this good to be checked in?

Sep 19 2017, 10:33 AM

Sep 18 2017

lemo updated the diff for D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump).

Fixed the FreeBSD/Windows break : the intention was to keep Process::WillResume() and Process::DoResume() "in-sync", but this had the unfortunate consequence of breaking Process sub-classes which don't override WillResume().

Sep 18 2017, 3:35 PM
lemo added inline comments to D37923: Implement interactive command interruption.
Sep 18 2017, 2:38 PM
lemo added inline comments to D37923: Implement interactive command interruption.
Sep 18 2017, 2:33 PM

Sep 15 2017

lemo updated the diff for D37923: Implement interactive command interruption.

Incorporating CR feedback.

Sep 15 2017, 3:43 PM
lemo added inline comments to D37923: Implement interactive command interruption.
Sep 15 2017, 2:17 PM
lemo added inline comments to D37923: Implement interactive command interruption.
Sep 15 2017, 2:03 PM
lemo updated the diff for D37923: Implement interactive command interruption.

Split the SIGINT handles fixes into a stanalone patch

Sep 15 2017, 1:33 PM
lemo created D37926: Fix the SIGINT handlers.
Sep 15 2017, 1:28 PM
lemo created D37923: Implement interactive command interruption.
Sep 15 2017, 1:00 PM

Sep 13 2017

lemo added a comment to D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump).

@Jim: Good point, I created this bug to track this as you suggested:
Bug 34594 - Revisit the failure path for Process::Resume() to avoid leaking Stopped->Running->Stopped events

Sep 13 2017, 10:50 AM
lemo updated the diff for D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump).

Adding test coverage

Sep 13 2017, 10:26 AM

Sep 12 2017

lemo updated the diff for D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump).

Revised patch based on the review feedback: I looked into updating the running state after everything else succeeds, but it proved a bit awkward since 1) TrySetRunning() can fail and 2) if we check the running state then use SetRunning() instead of TrySetRunning() it opens the possibility for a race.

Sep 12 2017, 1:32 PM

Sep 8 2017

lemo added a comment to D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump).

Thanks everyone for the feedback.

Sep 8 2017, 6:01 PM
lemo updated the summary of D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump).
Sep 8 2017, 4:29 PM
lemo created D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump).
Sep 8 2017, 4:23 PM

Sep 7 2017

lemo added a comment to D37527: Fix for bug 34510 - Minidump target does not resolve new symbols correctly.

Thanks everyone. I don't have commit permissions, can someone please commit this on my behalf?

Sep 7 2017, 11:05 AM

Sep 6 2017

lemo updated the summary of D37527: Fix for bug 34510 - Minidump target does not resolve new symbols correctly.
Sep 6 2017, 2:57 PM
lemo updated the summary of D37527: Fix for bug 34510 - Minidump target does not resolve new symbols correctly.
Sep 6 2017, 2:56 PM
lemo updated subscribers of D37527: Fix for bug 34510 - Minidump target does not resolve new symbols correctly.
Sep 6 2017, 1:16 PM
lemo created D37527: Fix for bug 34510 - Minidump target does not resolve new symbols correctly.
Sep 6 2017, 1:02 PM